Skip to content

Conversation

@Julio-Guerra
Copy link
Contributor

What does this PR do? What is the motivation?

Fix the standalone AAP setup landing page, removing incoherent details regarding APM.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@Julio-Guerra Julio-Guerra requested a review from a team as a code owner April 10, 2025 07:30
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Apr 10, 2025
@Julio-Guerra
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 10, 2025

View all feedbacks in Devflow UI.

2025-04-10 07:57:56 UTC ℹ️ Start processing command /merge


2025-04-10 07:58:02 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-04-10 11:58:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@drichards-87 drichards-87 added the editorial review Waiting on a more in-depth review label Apr 10, 2025
@drichards-87
Copy link
Contributor

@Julio-Guerra Can we hold off on merging this until Monday? We're getting the security nav PRs ready and are trying to avoid introducing any merge conflicts. I can also try and port these changes over manually into the main update PR that we're working on (which will be merged Monday morning).

@Julio-Guerra
Copy link
Contributor Author

@Julio-Guerra Can we hold off on merging this until Monday? We're getting the security nav PRs ready and are trying to avoid introducing any merge conflicts. I can also try and port these changes over manually into the main update PR that we're working on (which will be merged Monday morning).

This new standalone/ folder was created yesterday to avoid conflicts 🤔 Are you sure it would create conflicts to merge it?

@Julio-Guerra Julio-Guerra changed the title Update _index.md Remove standalone AAP's doc mentions to APM Apr 10, 2025
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Julio-Guerra I took a closer look at the PR and think it’s safe to merge without any concern about merge conflicts. I added one suggestion to use ASM, since the product name changes won’t be live until Monday. I will go ahead and commit the change and then merge the PR after the build job checks finish running.

@drichards-87
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 10, 2025

View all feedbacks in Devflow UI.

2025-04-10 23:03:18 UTC ℹ️ Start processing command /merge


2025-04-10 23:03:24 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-04-10 23:07:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 18m (p90).


2025-04-10 23:25:54 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit b453cba into master Apr 10, 2025
18 of 24 checks passed
@dd-mergequeue dd-mergequeue bot deleted the julio.guerra/fix-aap-standalone-index branch April 10, 2025 23:25
estherk15 pushed a commit that referenced this pull request May 8, 2025
Co-authored-by: drichards-87 <56796055+drichards-87@users.noreply.github.com>
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review mergequeue-status: done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants