-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove standalone AAP's doc mentions to APM #28700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview links (active after the
|
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
|
@Julio-Guerra Can we hold off on merging this until Monday? We're getting the security nav PRs ready and are trying to avoid introducing any merge conflicts. I can also try and port these changes over manually into the main update PR that we're working on (which will be merged Monday morning). |
This new standalone/ folder was created yesterday to avoid conflicts 🤔 Are you sure it would create conflicts to merge it? |
drichards-87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Julio-Guerra I took a closer look at the PR and think it’s safe to merge without any concern about merge conflicts. I added one suggestion to use ASM, since the product name changes won’t be live until Monday. I will go ahead and commit the change and then merge the PR after the build job checks finish running.
content/en/security/application_security/threats/setup/standalone/_index.md
Outdated
Show resolved
Hide resolved
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
Co-authored-by: drichards-87 <56796055+drichards-87@users.noreply.github.com> Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
What does this PR do? What is the motivation?
Fix the standalone AAP setup landing page, removing incoherent details regarding APM.
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes