-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Split RUM SDK performance impact docs #32685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split RUM SDK performance impact docs #32685
Conversation
Preview links (active after the
|
aleksandr-gringauz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
rtrieu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this PR! left some feedback and suggestions for your review. i'm going to make a commit to add the ios sdk performance impact page to the left nav.
content/en/real_user_monitoring/application_monitoring/android/sdk_performance_impact.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md
Show resolved
Hide resolved
content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md
Outdated
Show resolved
Hide resolved
…/sdk_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
…_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
…_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
…_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
…_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
…_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
…_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
…_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
…_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
…_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
* remove iOS mention from the Android benchmark docs * add iOS benchmark docs * add ios sdk perf impact to left nav * Update content/en/real_user_monitoring/application_monitoring/android/sdk_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Update content/en/real_user_monitoring/application_monitoring/ios/sdk_performance_impact.md Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> --------- Co-authored-by: Rosa Trieu <rosa.trieu@datadoghq.com> Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
What does this PR do? What is the motivation?
The RUM SDK Benchmark Docs used to be nested under the Android section, while it covers both our Android and iOS SDKs. This PR fixes this by splitting the docs in two pages, one that stays under the Android section, and the other that moves to iOS.
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes