Remove multiple endpoints support #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ class Client | |||
| # [[api_key1, application_key1], [api_key2, application_key2]] | |||
| # Hash to be able to specify different endpoints: | |||
| # {'https://app.example.com' => [[api_key1, application_key1], [api_key2, application_key2]]} | |||
| def initialize(api_key, application_key=nil, host=nil, device=nil, silent=true, timeout=nil, extra_endpoints=nil) | |||
| def initialize(api_key, application_key=nil, host=nil, device=nil, silent=true, timeout=nil) | |||
There was a problem hiding this comment.
The comments above should be updated to remove any mention of extra_endpoints.
|
LGTM! |
This library exists to interact with the API (mute monitors, create dashboards, ...), and for most of these actions it doesn't make sense to send them to multiple accounts. It makes sense for metrics/events/service_checks, and for this usage dogstatsd-ruby makes more sense. (as it uses the forwarder included with the agent which can easily send to multiple accounts)
degemer
force-pushed
the
quentin/remove-multi-endpoints
branch
from
c189671
to
f347d48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library exists to interact with the API (mute monitors, create
dashboards, ...), and for most of these actions it doesn't make sense to
send them to multiple accounts.
It makes sense for metrics/events/service_checks, and for this usage
dogstatsd-ruby makes more sense. (as it uses the forwarder included with
the agent which can easily send to multiple accounts)