Add profile metadata for palo alto #10956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pducolin
previously approved these changes
Jan 3, 2022
| symbol: | ||
| OID: 1.3.6.1.2.1.1.1.0 | ||
| name: sysDescr | ||
| match_pattern: 'Palo Alto Networks\s+(PA-\d+ series firewall|WildFire Appliance|VM-Series firewall)' |
There was a problem hiding this comment.
❓ question
Have you considered catching anything after Palo Alto Networks instead of trying to match with hardcoded names ?
There was a problem hiding this comment.
Yes, thought about that, but I wanted to be conservative for now since we don't have many cases and I didn't wanted to risk capturing unwanted things.
AlexandreYang
force-pushed
the
alex/snmp_profile_palo_alto
branch
from
53e28f1
to
87f72c3
Compare
pducolin
approved these changes
Jan 5, 2022
cswatt
pushed a commit
that referenced
this pull request
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add profile metadata for palo alto