Add OpenShift integration metadata #1902
Conversation
The link is not working right now, but will once merged
| "name": "openshift", | ||
| "display_name": "OpenShift", | ||
| "short_description": "The Kubernetes platform for big ideas", | ||
| "creates_events": false, |
There was a problem hiding this comment.
Should we add the metric_to_check and metric_prefix attributes for this integration ?
There was a problem hiding this comment.
metric_prefix for sure, metric_to_check would be tricky as the quota metrics are only collected if some quotas are set, so we don't have a constant metric for now to work with
| @@ -0,0 +1,42 @@ | |||
| openshift.clusterquota.cpu.used,gauge,,cpu,,Observed cpu usage by cluster resource quota for all namespaces,0,openshift | |||
There was a problem hiding this comment.
We should keep the headers line here: metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name
|
No transparent background for the avatars-bot logo ? |
|
@zippolyte Indeed, PR ready and waiting for RC1 to be out :) |
openshift/README.md
Outdated
|
|
||
| ## Setup | ||
|
|
||
| Datadog's [Kubernetes integration][1] supports OpenShift versions 3.3 and up. No additionnal setup is required for OpenShift-specific tags to be collected. |
openshift/README.md
Outdated
|
|
||
| Datadog's [Kubernetes integration][1] supports OpenShift versions 3.3 and up. No additionnal setup is required for OpenShift-specific tags to be collected. | ||
|
|
||
| [Cluster resource quota][2] metrics are collected by the leader agent, you must [configure the Agent event collection and leader election][3] in order to send them to your Datadog application. |
There was a problem hiding this comment.
[Cluster resource quota][2] metrics are collected by the leader agent. Configure the Agent event collection and leader election][3] in order to send metrics to Datadog.
Also, if "agent" in the first sentence refers to the Datadog Agent, capitalize Agent.
openshift/README.md
Outdated
| See [metadata.csv][4] for a list of metrics provided by this check. | ||
|
|
||
| ### Events | ||
| The Openshift check does not include any events at this time. |
There was a problem hiding this comment.
Camelcase OpenShift for consistency.
openshift/README.md
Outdated
|
|
||
| ### Service Checks | ||
|
|
||
| The Openshift check does not include any Service Checks at this time. |
There was a problem hiding this comment.
Camelcase OpenShift for consistency.
What does this PR do?
This PR introduces the "virtual" OpenShift integration, for metrics added in DataDog/datadog-agent#1945
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?