[kube] Reduce apiserver request count for pod_service_mapper #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
force-pushed
the
xvello/kubeservicemapper_delay
branch
from
e6c6211
to
1e85a66
Compare
hkaj
reviewed
Jun 15, 2017
kubernetes/check.py
Outdated
| @@ -32,6 +32,8 @@ | |||
| DEFAULT_COLLECT_EVENTS = False | |||
| DEFAULT_NAMESPACES = ['default'] | |||
|
|
|||
| DEFAULT_SERVICE_EVENT_FREQ = 5 | |||
There was a problem hiding this comment.
this should be in seconds. You can set it to 5 * 60 to be explicit.
There was a problem hiding this comment.
that's legit! pushing changes. As sister PR is merged, tests should pass now
kubernetes/check.py
Outdated
| @@ -106,14 +108,17 @@ def __init__(self, name, init_config, agentConfig, instances=None): | |||
| self._collect_events = _is_affirmative(inst.get('collect_events', DEFAULT_COLLECT_EVENTS)) | |||
| if self._collect_events: | |||
| self.event_retriever = self.kubeutil.get_event_retriever() | |||
| elif self.kubeutil.collect_service_tag: | |||
| # Only fetch service and pod events for service mapping | |||
| event_delay = inst.get('service_tag_update_freq', DEFAULT_SERVICE_EVENT_FREQ) * 60 | |||
kubernetes/conf.yaml.example
Outdated
| @@ -51,6 +51,13 @@ instances: | |||
| # | |||
| # collect_events: false | |||
| # | |||
| # Matching the pods to Kubernetes services requires to retrieve events regularly. | |||
| # To reduce the traffic to the apiserver, we only query them every 5 minutes, adding a delay | |||
| # in pod -> service matching. You can configure it below (in minutes) or disable kube_service | |||
xvello
force-pushed
the
xvello/kubeservicemapper_delay
branch
from
1e85a66
to
e13a2ef
Compare
- add collect_service_tags option to disable collection - add service_tag_update_freq to reduce event requests
xvello
force-pushed
the
xvello/kubeservicemapper_delay
branch
from
e13a2ef
to
c151abb
Compare
hkaj
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR for DataDog/dd-agent#3387, to reduce apiserver requests