Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template specs typos #6912

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Fix template specs typos #6912

merged 2 commits into from
Jun 17, 2020

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Jun 17, 2020 •
edited

What does this PR do?

Fix typos in the template specs.
Thanks @sarina-dd for catching those

Motivation

Additional Notes

Reviewers should look at these template files https://github.com/DataDog/integrations-core/pull/6912/files#diff-6377ddcbfd871f9b254efe11fe46bd9e https://github.com/DataDog/integrations-core/pull/6912/files#diff-e114a87be8a2a6ec851b504799fd8d35

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested review from anshumgargdd and a team as code owners June 17, 2020 08:15
@codecov
Copy link

codecov bot commented Jun 17, 2020 •
edited

Codecov Report

Merging #6912 into master will decrease coverage by 5.08%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...ts/tooling/configuration/consumers/test_example.py 100.00% <ø> (ø)
kong/datadog_checks/kong/kong.py
proxysql/tests/conftest.py
ignite/tests/test_check.py
http_check/tests/test_integration_e2e.py
nginx/tests/test_unit.py
...datadog_checks/kube_controller_manager/__init__.py
hazelcast/datadog_checks/hazelcast/__about__.py
http_check/datadog_checks/http_check/__init__.py
...xternal_dns/datadog_checks/external_dns/metrics.py
... and 732 more

@coignetp coignetp merged commit af0bfc5 into master Jun 17, 2020
@coignetp coignetp deleted the paul/template-specs branch June 17, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

@sarina-dd sarina-dd sarina-dd approved these changes

@anshumgargdd anshumgargdd Awaiting requested review from anshumgargdd

Assignees
No one assigned
Labels
dev/tooling integration/active_directory integration/activemq_xml integration/activemq integration/airflow integration/ambari integration/apache integration/ceph integration/confluent_platform integration/consul integration/datadog_checks_dev integration/druid integration/elastic integration/flink integration/fluentd integration/gitlab integration/hazelcast integration/hive integration/hivemq integration/ibm_mq integration/ignite integration/istio integration/jboss_wildfly integration/kong integration/mongo integration/nginx_ingress_controller integration/nginx integration/openmetrics integration/postgres integration/rethinkdb integration/sidekiq integration/sqlserver integration/tenable integration/tomcat integration/twistlock integration/vault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coignetp @FlorianVeaux @sarina-dd