Only declare the Agent package if not already declared #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the package to be declared even when we don't install it, since there's code that depends on it. Our current approach is to always declare it, which works if the package is installed by something else than Puppet (eg: chocolatey), since our declaration would not try to install it again and the code that depends on that declaration would still be happy. However, in case the package is being installed by a different Puppet module, it would fail with a `Duplicate declaration` error.
mx-psi
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We need the Agent
packageto be declared even when we don't install it,since there's code that depends on it. Our current approach is to always
declare it, which works if the package is installed by something other than
Puppet (eg: chocolatey), since our declaration would not try to install it
again and the code that depends on that declaration would still be happy.
However, in case the package is being installed by a different Puppet
module, it would fail with a
Duplicate declarationerror.Motivation
Bug report.