This PR fixes the ability to add vhosts and queues into the #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integration of rabbitmq metrics.
|
@talwai can you take a look? |
|
👍 |
|
@mleone896 Thanks for contributing! Your change works great, and we've fixed the issue with our CI environment that caused the Travis red-light in the first place. Merging this |
talwai
added a commit
that referenced
this pull request
Sep 1, 2015
…s_for_queues_vhosts This PR fixes the ability to add vhosts and queues into the RabbitMQ integration
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
…features_for_queues_vhosts This PR fixes the ability to add vhosts and queues into the RabbitMQ integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integration of rabbitmq metrics.
Rabbbitmq integration respects queues and vhosts. The way the module and template was written it did not give you that functionality. I can add exchanges and brokers if thats something thats needed also, I'm running this code in prod right now, also just talked to support (Martin) giving him the heads up this PR was coming your way. Hope this helps.