From 519995ccdbf98f8bd91f8e83c5a60625c05f150b Mon Sep 17 00:00:00 2001 From: Devin Ford Date: Tue, 11 Apr 2023 11:01:49 -0400 Subject: [PATCH 1/4] feat: setup deploy job for multi platform frontend build --- .github/workflows/release.yml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3afeb7a6..17b51073 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -50,9 +50,27 @@ jobs: for i in "${IMAGES[@]}" do echo "$i" + + # Since frontend is images are build to be platform specific, we need to tag and deploy accordingly + if [[ "$i" == *"storedog/frontend"* ]]; then + + # build amd image + docker pull "$i":amd-latest + docker tag "$i":amd-latest "$i":amd-$TAG + docker push "$i":amd-$TAG + + # build arm image + docker pull "$i":arm-latest + docker tag "$i":arm-latest "$i":arm-$TAG + docker push "$i":arm-$TAG + + continue + fi + docker pull "$i":latest docker tag "$i":latest "$i":$TAG docker push "$i":$TAG + done echo "All done" From 7a45f8b786607317dfe50c0063c3e27ccc664d2c Mon Sep 17 00:00:00 2001 From: Devin Ford Date: Tue, 11 Apr 2023 11:09:42 -0400 Subject: [PATCH 2/4] chore: udpate comment --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 17b51073..d4546742 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -54,12 +54,12 @@ jobs: # Since frontend is images are build to be platform specific, we need to tag and deploy accordingly if [[ "$i" == *"storedog/frontend"* ]]; then - # build amd image + # deploy frontend amd image docker pull "$i":amd-latest docker tag "$i":amd-latest "$i":amd-$TAG docker push "$i":amd-$TAG - # build arm image + # deploy frontend arm image docker pull "$i":arm-latest docker tag "$i":arm-latest "$i":arm-$TAG docker push "$i":arm-$TAG From 43cbdbf55c02602b8f350d06db80a2cc9f6db738 Mon Sep 17 00:00:00 2001 From: Devin Ford Date: Tue, 11 Apr 2023 11:18:21 -0400 Subject: [PATCH 3/4] fix: tagging convention --- .github/workflows/release.yml | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d4546742..f85d39fb 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -50,27 +50,19 @@ jobs: for i in "${IMAGES[@]}" do echo "$i" - + + docker pull "$i":latest + docker tag "$i":latest "$i":$TAG + docker push "$i":$TAG + # Since frontend is images are build to be platform specific, we need to tag and deploy accordingly if [[ "$i" == *"storedog/frontend"* ]]; then - - # deploy frontend amd image - docker pull "$i":amd-latest - docker tag "$i":amd-latest "$i":amd-$TAG - docker push "$i":amd-$TAG - # deploy frontend arm image docker pull "$i":arm-latest docker tag "$i":arm-latest "$i":arm-$TAG docker push "$i":arm-$TAG - - continue fi - docker pull "$i":latest - docker tag "$i":latest "$i":$TAG - docker push "$i":$TAG - done echo "All done" From 246476e9cd269f2f0b6cf09959be31d69ec4aa26 Mon Sep 17 00:00:00 2001 From: Devin Ford Date: Tue, 11 Apr 2023 11:20:30 -0400 Subject: [PATCH 4/4] feat: fix frontend to match --- .github/workflows/frontend.yml | 2 +- services/frontend/Dockerfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/frontend.yml b/.github/workflows/frontend.yml index 02cb13b6..c3bb5320 100644 --- a/.github/workflows/frontend.yml +++ b/.github/workflows/frontend.yml @@ -46,7 +46,7 @@ jobs: context: ./services/frontend platforms: linux/amd64 push: true - tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/frontend:amd-latest + tags: ${{ secrets.PUBLIC_ECR_REGISTRY }}/storedog/frontend:latest - name: Build and push ARM uses: docker/build-push-action@v2 diff --git a/services/frontend/Dockerfile b/services/frontend/Dockerfile index eca48707..f78e2246 100644 --- a/services/frontend/Dockerfile +++ b/services/frontend/Dockerfile @@ -2,4 +2,4 @@ FROM node:16.18.0 as builder WORKDIR /storedog-app COPY . . EXPOSE 3000 -RUN ["yarn","install"] \ No newline at end of file +RUN ["yarn","install"]