Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametric: bump golang version #1699

Merged
merged 1 commit into from Oct 17, 2023
Merged

parametric: bump golang version #1699

merged 1 commit into from Oct 17, 2023

Conversation

ahmed-mez
Copy link
Contributor

Description

bump golang version to 1.20 in parametric tests

Motivation

Required for DataDog/dd-trace-go#2274

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@ahmed-mez ahmed-mez requested review from a team as code owners October 17, 2023 08:42
@ahmed-mez
Copy link
Contributor Author

@cbeauchesne The parametric tests for golang are passing, could you review / approve? thanks!

@ahmed-mez ahmed-mez merged commit f3a84d7 into main Oct 17, 2023
156 of 173 checks passed
@ahmed-mez ahmed-mez deleted the ahmed/bump-golang-version branch October 17, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants