Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zachg/parametric enable w3c phase1 tests python #1842

Merged
merged 10 commits into from Nov 27, 2023

Conversation

ZStriker19
Copy link
Contributor

Description

Enable tracestate propagation test

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

…hub.com:DataDog/system-tests into zachg/parametric-enable-w3c-phase1-tests-python
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are tests failures. Where are waiting for the merge of a PR in Python tracer?

@ZStriker19 ZStriker19 marked this pull request as draft November 15, 2023 16:48
@ZStriker19 ZStriker19 force-pushed the zachg/parametric-enable-w3c-phase1-tests-python branch from 019d0df to f5b15ab Compare November 15, 2023 16:55
@ZStriker19 ZStriker19 force-pushed the zachg/parametric-enable-w3c-phase1-tests-python branch from f5b15ab to 3b15125 Compare November 15, 2023 17:49
@ZStriker19
Copy link
Contributor Author

Sorry, forgot we need to release version with these changes first.

@ZStriker19 ZStriker19 marked this pull request as ready for review November 21, 2023 19:05
@ZStriker19
Copy link
Contributor Author

Ok now that 2.3.0 is out we should be all set.

@ZStriker19 ZStriker19 force-pushed the zachg/parametric-enable-w3c-phase1-tests-python branch from 0455a2f to 571162f Compare November 22, 2023 18:32
@ZStriker19 ZStriker19 merged commit 7df16a5 into main Nov 27, 2023
165 checks passed
@ZStriker19 ZStriker19 deleted the zachg/parametric-enable-w3c-phase1-tests-python branch November 27, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants