Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GO]: parametic/ test default propagation style #1853

Merged
merged 9 commits into from Feb 5, 2024

Conversation

JianyiGao
Copy link
Contributor

@JianyiGao JianyiGao commented Nov 16, 2023

Description

  • Runs test_headers_precedence_propagationstyle_default_tracecontext_datadog for ddtrace-go<1.61.0.dev.
  • Runstest_headers_precedence_propagationstyle_default_datadog_tracecontext for ddtrace-go>=1.62.0.

Motivation

This PR test default propagation style for golang. Default style changed from tracecontext,datadog to datadog,tracecontext

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are tests failures in the CI.
I guess we are waiting for merge dd-trace-go. (if it's the case, it would be better to set the PR in Draft status)

@JianyiGao JianyiGao requested a review from a team as a code owner November 17, 2023 20:27
Copy link
Contributor

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the go changes, but the test skip changes look good to me

@mabdinur mabdinur force-pushed the jennie.gao/switch-context-propagation branch from e10b2a2 to 532c4e6 Compare February 5, 2024 18:37
Both tests will be skipped for `v1.61.0.dev <= context.library < v1.62.0` (v1.61.X will not be tested).  This will allow us to update system tests while the v1.61.0 release is in progress.
@mabdinur mabdinur force-pushed the jennie.gao/switch-context-propagation branch from 3da55bb to ff2b087 Compare February 5, 2024 19:26
@mabdinur mabdinur merged commit cf45c7d into main Feb 5, 2024
337 of 342 checks passed
@mabdinur mabdinur deleted the jennie.gao/switch-context-propagation branch February 5, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants