New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GO]: parametic/ test default propagation style #1853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are tests failures in the CI.
I guess we are waiting for merge dd-trace-go. (if it's the case, it would be better to set the PR in Draft status)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the go changes, but the test skip changes look good to me
e10b2a2
to
532c4e6
Compare
Both tests will be skipped for `v1.61.0.dev <= context.library < v1.62.0` (v1.61.X will not be tested). This will allow us to update system tests while the v1.61.0 release is in progress.
3da55bb
to
ff2b087
Compare
Description
test_headers_precedence_propagationstyle_default_tracecontext_datadogforddtrace-go<1.61.0.dev.test_headers_precedence_propagationstyle_default_datadog_tracecontextforddtrace-go>=1.62.0.ddtrace v1.61.0release is currently in progress (rc1 was just released). Changes in ddtrace/tracer: Switch default context propagation order dd-trace-go#2349 will go out in v1.62.0.Motivation
This PR test default propagation style for golang. Default style changed from
tracecontext,datadogtodatadog,tracecontextWorkflow
Once your PR is reviewed, you can merge it! ❤️
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...). If this PR modifies any system-tests internal, then add therun-all-scenarioslabel (more info).build-some-imagelabel is present