New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor kafka cross tracer tests to use only java buddy #2051
Conversation
|
I guess the failures on the CI are related with these changes. I change the status of the PR as "Draft" |
…ration tests" This reverts commit 716d573.
Could you add more context for that decision, just to allow futur contributor to understand the why? cc @wantsui |
|
no need to rebuild buddies image here |
@tabgok and I discussed this. The reasoning to only have one buddy as opposed to one per language is mainly to speed up testing. If trace context propagation works for language A to language B, and also works from language A to language C, then it can be inferred that propagation works from language B to language C. It also works better with the layout of the Feature Parity Dashboard. |
Indeed it'll be faster :)
We need to make the FPD handling any use case. If one day it's the only reason the shape a tests, please ping us to find a solution, because tests design must not be driven by this reason. (And actually, I think it could have handled this use case nicely, because we could have grouped all tests in one feature). So far, AGTM! |
Motivation
We want one feature for kafka testing, not one per language like initially implemented
Changes
Eliminates all but one test class for Kafka cross tracer testing. Uses the java buddy since Java context propagation is fully implemented for kafka
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...) are presentsbuild-XXX-imagelabel is present