Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeJS] Add graphql resolver arguments source test for iast #2145

Merged
merged 6 commits into from Feb 16, 2024

Conversation

uurien
Copy link
Contributor

@uurien uurien commented Feb 13, 2024

Motivation

Add system test to the feature implemented in DataDog/dd-trace-js#3835

Changes

Add new graphql endpoint and new system test

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@uurien uurien force-pushed the ugaitz/graphql-sources-nodejs branch from d93e344 to 04fb855 Compare February 15, 2024 13:01
@uurien
Copy link
Contributor Author

uurien commented Feb 16, 2024

All the failing test are in PHP, it doesn't seems like it's related with this PR

@uurien uurien marked this pull request as ready for review February 16, 2024 09:32
@uurien uurien requested review from a team as code owners February 16, 2024 09:32
@uurien uurien merged commit fbd277f into main Feb 16, 2024
136 of 167 checks passed
@uurien uurien deleted the ugaitz/graphql-sources-nodejs branch February 16, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants