diff --git a/.claude/CLAUDE.md b/.claude/CLAUDE.md index 577a9829fe8..4718e7a8f4b 100644 --- a/.claude/CLAUDE.md +++ b/.claude/CLAUDE.md @@ -27,6 +27,10 @@ Read and follow these rules in EVERY interaction: 10. **`.cursor/rules/java-endpoint-prompt.mdc`** - Java endpoint creation prompts 11. **`.cursor/rules/promptfoo-llm.mdc`** - Promptfoo LLM testing guidelines +## Pull request review guidelines + +12. **`.cursor/rules/pr-review.mdc`** - Pull Request review guidelines and checklist + --- ## Quick Reference diff --git a/.cursor/rules/pr-review.mdc b/.cursor/rules/pr-review.mdc new file mode 100644 index 00000000000..938f5ebf964 --- /dev/null +++ b/.cursor/rules/pr-review.mdc @@ -0,0 +1,20 @@ +--- +description: Rules for reviewing Pull Requests in system-tests +globs: +alwaysApply: false +--- +# PR Review Guidelines + +## Test Activation/Deactivation Changes + +When reviewing PRs that include changes to test activation or deactivation (manifest files or test decorators), you must verify that all modifications comply with the rules and guidelines documented in: + +- [skip-tests.md](mdc:docs/edit/skip-tests.md) - When and how to use decorators vs manifests +- [manifest.md](mdc:docs/edit/manifest.md) - Manifest file format, syntax, and best practices + +Key verification points: +- Manifests are preferred over decorators when possible +- Correct format and syntax are used +- Version specifications use the `v` prefix (e.g., `v1.2.0`) +- Special YAML characters are properly quoted +- `bug` and `flaky` markers include JIRA ticket references diff --git a/AGENTS.md b/AGENTS.md index ea658722c13..0ea15d10be1 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -25,8 +25,12 @@ Read and follow these rules in EVERY interaction: ## Manual Rules (Apply Only When Explicitly Requested) -10. **`.cursor/rules/java-endpoint-prompt.mdc`** - Java endpoint creation prompts -11. **`.cursor/rules/promptfoo-llm.mdc`** - Promptfoo LLM testing guidelines +11. **`.cursor/rules/java-endpoint-prompt.mdc`** - Java endpoint creation prompts +12. **`.cursor/rules/promptfoo-llm.mdc`** - Promptfoo LLM testing guidelines + +## Pull request review guidelines + +13. **`.cursor/rules/pr-review.mdc`** - Pull Request review guidelines and checklist ---