From 316ae290c225346559164f2fbef85047ef511dcc Mon Sep 17 00:00:00 2001 From: uuqjz Date: Tue, 13 Aug 2024 10:36:11 +0200 Subject: [PATCH 1/2] Fix deletion of temporary empty-nodes --- src/features/serialize/defaultDiagram.json | 18 ------------------ src/features/toolPalette/edgeCreationTool.ts | 4 +++- 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/src/features/serialize/defaultDiagram.json b/src/features/serialize/defaultDiagram.json index 97a9f7b..340033b 100644 --- a/src/features/serialize/defaultDiagram.json +++ b/src/features/serialize/defaultDiagram.json @@ -163,24 +163,6 @@ "type": "node:storage", "children": [] }, - { - "position": { - "x": 420.76127480457006, - "y": 89.13650030066145 - }, - "size": { - "width": -1, - "height": -1 - }, - "strokeWidth": 0, - "selected": false, - "hoverFeedback": false, - "opacity": 1, - "features": {}, - "id": "xccftn", - "type": "empty-node", - "children": [] - }, { "position": { "x": 249, diff --git a/src/features/toolPalette/edgeCreationTool.ts b/src/features/toolPalette/edgeCreationTool.ts index 96d97b1..3d2160e 100644 --- a/src/features/toolPalette/edgeCreationTool.ts +++ b/src/features/toolPalette/edgeCreationTool.ts @@ -36,7 +36,7 @@ export class EdgeCreationTool extends CreationTool { if (this.edgeTargetElement) { // Pseudo edge target element must always be removed // regardless of whether the edge creation was successful or cancelled - this.element?.root.remove(this.edgeTargetElement); + this.edgeTargetElement.parent?.remove(this.edgeTargetElement); this.edgeTargetElement = undefined; } @@ -91,6 +91,8 @@ export class EdgeCreationTool extends CreationTool { // Add empty node to the graph and as a edge target root.add(this.edgeTargetElement); this.element.targetId = this.edgeTargetElement.id; + + console.log(root); } } return []; From 426f5788fcf099581ae4a3c34499ba40faf24c62 Mon Sep 17 00:00:00 2001 From: uuqjz Date: Tue, 13 Aug 2024 10:38:48 +0200 Subject: [PATCH 2/2] Clean console log --- src/features/toolPalette/edgeCreationTool.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/features/toolPalette/edgeCreationTool.ts b/src/features/toolPalette/edgeCreationTool.ts index 3d2160e..ead081e 100644 --- a/src/features/toolPalette/edgeCreationTool.ts +++ b/src/features/toolPalette/edgeCreationTool.ts @@ -91,8 +91,6 @@ export class EdgeCreationTool extends CreationTool { // Add empty node to the graph and as a edge target root.add(this.edgeTargetElement); this.element.targetId = this.edgeTargetElement.id; - - console.log(root); } } return [];