Feat: implementing complete banner management

[thapacodes4u]

feat/banners

[thapacodes4u]

@SlimDeluxe This PR is ready for a review. Please take a look when you are free. Thanks

[SlimDeluxe]

Pretty good 👍 , but some changes are needed:

1. Should say "Banners". The term "Positions" should not be exposed too much to the user, since this is something that developers set up once and a normal admin user never changes.

2. Should say "New position", it's clear from the context

3. Clicking on a position can open the View page like now, but the crossed sections should not be visible. The main focus here is to manage/upload banner images, which is what most admins do.
   See the changed labels (for your example "Website Banners") and additions below. You need to make it possible to fully manage banners in this screen, and not in "Edit position". In the end, "edit position" and common banner management are very different things here and should be separate, and banner management should be the primary focus and easily reachable (with as few clicks as possible).

4. In position edit, make this a section that wraps the image types records below.

5. Also remove banner management from here.

6. In banner creation, if HIDPI is set, do not require 2 uploads. The user should upload only the 2x size. The label could be improved, e.g. "Mobile @2x (1600×800, displayed as 800×400). The 1x size can be generated by the app — please see if you can do it on upload.

7. Banners should be sortable in the table.

8. See comment below

[thapacodes4u]

@SlimDeluxe Could you review this. Thanks

[SlimDeluxe]

You were very close before, but this now went in the wrong direction. It's nothing like I wanted and was in the wireframe.

1. The first dimension/point of entry is the list of positions.
2. Clicking on each should open a list of banners for that position. The user can create new ones and manage existing ones.
3. In that same list the banners can be sorted.
4. There isn't even a upload option for the banner images. It only displays the basic record info.

Please go back to the beginning, see the wireframe, my description, the PR comments and if there are some parts that are unclear, please let me know and we can have a call about this.

[thapacodes4u]

@SlimDeluxe Ya not showing image is a bug. I fix it. And I thought we were focusing on Banner itself so moved to using Banner resource. I think its clear now.

By the way I don't think we need view page for the Banner Position at all right?

[SlimDeluxe]

The problem with your second approach is that you are showing banners from all positions in a single table, but they are completely unrelated. Each of them is a separate "group" that is presented on a "position" (header, footer, sidebar...).

We almost never need the View page, so sure, you can delete it.

[thapacodes4u]

@SlimDeluxe Now you can review this.

• I have moved banner to the previous position as banner relation manager.
• I have removed view page for banner position
• when we are in the edit page the main focus is the banner relation manager rather then the banner position it self.
• Improved modal. And also handle the generation of lower images when uploading.
• Removed unnecessary test cases and policy and permission.
• Added few test that checks for rules and the image generation.
• Added sort in the relation manager table.
• Add the UI changes that you highlighted in above images

[SlimDeluxe]

Much better, but some changes are still required:

1. You need to separate the position management (editing) and banner management (upload, delete...). The first version was better in this regard: you had an "Edit" button on the position view page (see number 3 here). But maybe you can keep the position editing here and move the banner management to a new page for BannerPositionResource?
2. This "position edit" action should be available only to the user with the correct permission, therefore you need to separate the permissions for each of those. I suggest adding "Manage banners" to the Position resouce permissions, and removing non-relevant ones (I see you tried to do it but you named the method getPermissions˙ instead of getPermissionPrefixes`). Remember, most admins only manage banners and should not be allowed to edit the banner position, since it will most likely break the site. I've had this exact case happen in production with menus and menu items.
3. Each of the image types of the position should be a separate column here, so they shouldn't all be in one column like this.
   In our demo case, Desktop and Mobile should be two columns after the Name column. Clicking on the image should show it in the "lightbox" modal.

[SlimDeluxe]

Please see previous PR comment for required changes.

[thapacodes4u]

@SlimDeluxe Ready for review

[SlimDeluxe]

Update needed after ImageColumn changes in common

[thapacodes4u]

@SlimDeluxe Should be good to review this

[SlimDeluxe]

There's a problem here with this class:

You closed the PR for the previewable ImageColumn for some reason?
DataLinx/eclipsephp-common#3

[thapacodes4u]

@SlimDeluxe You are right that got closed by mistake. I have kept that to the draft thinking that we will migrate all plugin to F4 before we merge the custom ImageColumn.

But it should be fine to use that to test this PR.