From 4699d05d95e427e4c2dbe70ed74aed82deec8f99 Mon Sep 17 00:00:00 2001
From: Sergei Pavlov <spavlov@servicetitan.com>
Date: Wed, 6 Oct 2021 10:32:08 -0700
Subject: [PATCH] Optimize TypeInfoCollection (#42)

* Optimize TypeInfoCollection

* Small fix

* Refactor FindAncestor()
---
 .../Orm/Model/TypeInfoCollection.cs           | 63 +++++++++----------
 1 file changed, 28 insertions(+), 35 deletions(-)

diff --git a/Orm/Xtensive.Orm/Orm/Model/TypeInfoCollection.cs b/Orm/Xtensive.Orm/Orm/Model/TypeInfoCollection.cs
index 37a5975838..fc40174f1c 100644
--- a/Orm/Xtensive.Orm/Orm/Model/TypeInfoCollection.cs
+++ b/Orm/Xtensive.Orm/Orm/Model/TypeInfoCollection.cs
@@ -1,4 +1,4 @@
-// Copyright (C) 2007-2020 Xtensive LLC.
+// Copyright (C) 2007-2021 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 // Created by: Dmitri Maximov
@@ -34,14 +34,9 @@ public sealed class TypeInfoCollection
     /// An indexer that provides access to collection items.
     /// </summary>
     /// <exception cref="ArgumentException">Item was not found.</exception>
-    public TypeInfo this[Type key] {
-      get {
-        TypeInfo result;
-        if (!TryGetValue(key, out result))
-          throw new KeyNotFoundException(string.Format(Strings.TypeXIsNotRegistered, key.GetShortName()));
-        return result;
-      }
-    }
+    public TypeInfo this[Type key] => TryGetValue(key, out var result)
+      ? result
+      : throw new KeyNotFoundException(string.Format(Strings.TypeXIsNotRegistered, key.GetShortName()));
 
     /// <summary>
     /// An indexer that provides access to collection items by their <see cref="TypeInfo.TypeId"/>.
@@ -217,15 +212,13 @@ public IEnumerable<TypeInfo> FindDescendants(TypeInfo item, bool recursive)
     {
       ArgumentValidator.EnsureArgumentNotNull(item, "item");
 
-      HashSet<TypeInfo> result;
-      if (!descendantTable.TryGetValue(item, out result))
-        result = new HashSet<TypeInfo>();
-
-      foreach (var item1 in result) {
-        yield return item1;
-        if (recursive)
-          foreach (var item2 in FindDescendants(item1, true))
-            yield return item2;
+      if (descendantTable.TryGetValue(item, out var result)) {
+        foreach (var item1 in result) {
+          yield return item1;
+          if (recursive)
+            foreach (var item2 in FindDescendants(item1, true))
+              yield return item2;
+        }
       }
     }
 
@@ -251,12 +244,10 @@ public IEnumerable<TypeInfo> FindInterfaces(TypeInfo item, bool recursive)
     {
       ArgumentValidator.EnsureArgumentNotNull(item, "item");
 
-      HashSet<TypeInfo> result;
-      if (!interfaceTable.TryGetValue(item, out result))
-        result = new HashSet<TypeInfo>();
-
-      foreach (var item1 in result)
-        yield return item1;
+      if (interfaceTable.TryGetValue(item, out var result)) {
+        foreach (var item1 in result)
+          yield return item1;
+      }
 
       if (!recursive || item.IsInterface)
         yield break;
@@ -293,15 +284,13 @@ public IEnumerable<TypeInfo> FindImplementors(TypeInfo item, bool recursive)
     {
       ArgumentValidator.EnsureArgumentNotNull(item, "item");
 
-      HashSet<TypeInfo> result;
-      if (!implementorTable.TryGetValue(item, out result))
-        result = new HashSet<TypeInfo>();
-
-      foreach (var item1 in result) {
-        yield return item1;
-        if (recursive && !item1.IsInterface)
-          foreach (var item2 in FindDescendants(item1, true))
-            yield return item2;
+      if (implementorTable.TryGetValue(item, out var result)) {
+        foreach (var item1 in result) {
+          yield return item1;
+          if (recursive && !item1.IsInterface)
+            foreach (var item2 in FindDescendants(item1, true))
+              yield return item2;
+        }
       }
     }
 
@@ -336,9 +325,13 @@ public TypeInfo FindRoot(TypeInfo item)
     /// <exception cref="ArgumentNullException">When <paramref name="type"/> is <see langword="null"/>.</exception>
     private TypeInfo FindAncestor(Type type)
     {
-      if (type == WellKnownTypes.Object || type.BaseType == null)
+      if (type == WellKnownTypes.Object) {
         return null;
-      return Contains(type.BaseType) ? this[type.BaseType] : FindAncestor(type.BaseType);
+      }
+      return type.BaseType switch {
+        null => null,
+        var baseType => TryGetValue(baseType, out var typeInfo) ? typeInfo : FindAncestor(baseType)
+      };
     }
 
     #endregion