From d3313a713e86986352317e46724237976656ffe1 Mon Sep 17 00:00:00 2001
From: Aamogh <120258212+aamoghS@users.noreply.github.com>
Date: Sun, 9 Aug 2026 01:16:14 -0400
Subject: [PATCH 1/3] docs: membership is no longer scoped to a hackathon
 edition (#333)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

W1 changed `member` from unique(user_id, hackathon_id) to unique(user_id), but
two pieces of documentation still described the old shape — and one of them
contradicted the code directly beneath it.

- README said `member` is scoped to a hackathon and that "a paid year still
  hangs off an edition, so membership resolves the current hackathon". That is
  the bug W1 fixed: the day the next edition opened, every paying member read
  as a non-member. It now says what is true, including that the club half works
  with no hackathon in the database at all.
- `requireActiveMember`'s docblock claimed it resolves the current edition. The
  function body does not, and an inner comment said the opposite — a reader
  had to work out which half to believe.

Documentation only; no behaviour change.
---
 README.md                              | 22 +++++++++++++---------
 packages/api/src/routers/initiative.ts | 10 ++++------
 2 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/README.md b/README.md
index 7fc619e6..edaeb8e3 100644
--- a/README.md
+++ b/README.md
@@ -58,7 +58,7 @@ Two entities anchor the graph:
   `user_account_link`, and `stripe_payment.linked_user_id`.
 - **`hackathon`** — every event-scoped table cascades from it: teams,
   participants, projects, hackathon events, judges, judge assignments, judging
-  projects, judge queue, and maps. `member` is also scoped to a hackathon.
+  projects, judge queue, and maps.
 
 Nearly all foreign keys are `onDelete: "cascade"`, so deleting a user or a
 hackathon removes its dependent rows rather than orphaning them.
@@ -69,14 +69,18 @@ Two aspects share the database and touch nowhere:
 
 - **Hackathon** — editions, registration, teams, project submission, judging.
   Everything here hangs off a `hackathon` row.
-- **Club** — `initiative`, its applications, and the `project_leader` role.
-  Deliberately **not** scoped to a hackathon. A club project runs whenever
-  somebody leads one, and leading is a standing appointment rather than a
-  yearly re-grant. Nothing in this half is ever judged; judges only score
-  `hackathon_project`.
-
-`member` is the one crossing case: a paid year still hangs off an edition, so
-membership resolves the current hackathon even though initiatives do not.
+- **Club** — `member`, `membership_history`, `event`, `event_check_in`,
+  `initiative`, its applications, and the `project_leader` role. Deliberately
+  **not** scoped to a hackathon. A club project runs whenever somebody leads
+  one, and leading is a standing appointment rather than a yearly re-grant.
+  Nothing in this half is ever judged; judges only score `hackathon_project`.
+
+The two halves no longer cross. `member` used to be `unique(user_id,
+hackathon_id)`, which welded a paid year to an edition: the day the next
+hackathon opened, every paying member read as a non-member. It is now
+`unique(user_id)` and a membership is defined entirely by its own dates, with
+`membership_history` recording which years somebody held one. The club half
+therefore works with no hackathon in the database at all.
 
 #### One-off step — only for a database that already has the edition-scoped tables
 
diff --git a/packages/api/src/routers/initiative.ts b/packages/api/src/routers/initiative.ts
index 57bb7ed2..430ee700 100644
--- a/packages/api/src/routers/initiative.ts
+++ b/packages/api/src/routers/initiative.ts
@@ -70,14 +70,12 @@ function canManage(
 /**
  * Applying is a member benefit, so it needs a membership that has not lapsed.
  *
- * Initiatives are unscoped but membership is not — a paid year still hangs off
- * an edition, so this resolves the current one. No edition means nobody has a
- * live membership to check, which refuses rather than waving everyone through.
+ * Keyed on the person alone. This used to resolve a "current edition" and look
+ * the membership up against it, so between hackathons — when no edition
+ * qualified — it refused everybody, which is how the club half went dead
+ * outside event season.
  */
 async function requireActiveMember(db: Reader, userId: string) {
-  // Initiatives were deliberately un-scoped from hackathons; membership now is
-  // too. This previously resolved a current edition and refused everyone when
-  // none existed, which is how the club half went dead outside event season.
   const member = await db.query.members.findFirst({
     where: eq(members.userId, userId),
     columns: { isActive: true, membershipEndDate: true },

From ec281195535596e7f0e50079acf280fe828b041e Mon Sep 17 00:00:00 2001
From: Aamogh <120258212+aamoghS@users.noreply.github.com>
Date: Sun, 9 Aug 2026 01:28:19 -0400
Subject: [PATCH 2/3] =?UTF-8?q?fix(admin):=20restore=20the=20Table=20Cards?=
 =?UTF-8?q?=20tab=20=E2=80=94=20judging=20cannot=20start=20without=20it=20?=
 =?UTF-8?q?(#338)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Judges score by scanning the QR on a team's table card: the scoring form only
opens after startByQrCode succeeds. TableCards.tsx renders those cards and is
the only consumer of judge.tableCards — and nothing imported it, so no card
could be printed and no judge could open the form. Judging was unstartable.

Lost when I split this work into a stack: branch 1 took the pre-stack version
of this page, so the tab and its import never reached main, and the mobile-nav
fix (seven tabs in a five-column grid, with Table Cards and Email laid out off
the right edge of the phone) went with it. Both are restored here.

Found by walking the organiser and judge journeys against main. Nothing failed
— the component compiled, 426 tests passed, and the missing tab was invisible
to all of it.
---
 .../(portal)/admin/hackathons/[id]/page.tsx   | 20 +++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/sites/mainweb/app/(portal)/admin/hackathons/[id]/page.tsx b/sites/mainweb/app/(portal)/admin/hackathons/[id]/page.tsx
index 7b6a7864..23848239 100644
--- a/sites/mainweb/app/(portal)/admin/hackathons/[id]/page.tsx
+++ b/sites/mainweb/app/(portal)/admin/hackathons/[id]/page.tsx
@@ -13,7 +13,8 @@ import { AnalyticsTab } from "@/components/admin/hackathons/AnalyticsTab";
 import { EventsTab } from "@/components/admin/hackathons/EventsTab";
 import { JudgesTab } from "@/components/admin/hackathons/JudgesTab";
 import { AnnouncementsTab } from "@/components/admin/hackathons/AnnouncementsTab";
-import { Gavel, Megaphone } from "lucide-react";
+import { TableCards } from "@/components/admin/hackathons/TableCards";
+import { Gavel, Megaphone, QrCode } from "lucide-react";
 
 type Tab =
   | "events"
@@ -21,7 +22,8 @@ type Tab =
   | "attendees"
   | "analytics"
   | "judges"
-  | "announcements";
+  | "announcements"
+  | "tables";
 
 export default function AdminHackathonDashboard() {
   const { status } = useSession();
@@ -59,6 +61,11 @@ export default function AdminHackathonDashboard() {
       icon: <IconChart className="w-5 h-5" />,
     },
     { id: "judges", label: "Judges", icon: <Gavel className="w-5 h-5" /> },
+    {
+      id: "tables",
+      label: "Table Cards",
+      icon: <QrCode className="w-5 h-5" />,
+    },
     {
       id: "announcements",
       label: "Email",
@@ -189,6 +196,7 @@ export default function AdminHackathonDashboard() {
             <AnalyticsTab hackathonId={hackathon.id} />
           )}
           {activeTab === "judges" && <JudgesTab hackathonId={hackathon.id} />}
+          {activeTab === "tables" && <TableCards hackathonId={hackathon.id} />}
           {activeTab === "announcements" && (
             <AnnouncementsTab hackathonId={hackathon.id} />
           )}
@@ -196,7 +204,11 @@ export default function AdminHackathonDashboard() {
       </main>
 
       {/* MOBILE BOTTOM NAVIGATION - Enhanced */}
-      <div className="md:hidden fixed bottom-0 left-0 right-0 bg-[var(--bg-primary)]/98 backdrop-blur-2xl border-t border-[var(--border-subtle)] z-40 grid grid-cols-5 pb-safe">
+      {/* Scrolls horizontally rather than a fixed 5-column grid: there are
+          seven tabs, so Table Cards and Email were laid out off the right edge
+          of the phone an organiser actually carries — unreachable, with nothing
+          to suggest they existed. */}
+      <div className="md:hidden fixed bottom-0 left-0 right-0 bg-[var(--bg-primary)]/98 backdrop-blur-2xl border-t border-[var(--border-subtle)] z-40 flex overflow-x-auto pb-safe [scrollbar-width:none] [&::-webkit-scrollbar]:hidden">
         {/* Top gradient overlay */}
         <div className="absolute top-0 left-0 right-0 h-[1px] bg-gradient-to-r from-transparent via-white/10 to-transparent" />
 
@@ -204,7 +216,7 @@ export default function AdminHackathonDashboard() {
           <button
             key={tab.id}
             onClick={() => setActiveTab(tab.id)}
-            className={`group relative flex flex-col items-center justify-center py-3 gap-1 transition-colors ${
+            className={`group relative shrink-0 basis-1/5 flex flex-col items-center justify-center py-3 gap-1 transition-colors ${
               activeTab === tab.id ? "text-accent" : "text-text-muted"
             }`}
           >

From ef8ad3adb416271817462b572c98441467fae813 Mon Sep 17 00:00:00 2001
From: Aamogh <120258212+aamoghS@users.noreply.github.com>
Date: Sun, 9 Aug 2026 01:28:58 -0400
Subject: [PATCH 3/3] fix(portal): a blank graduation year no longer blocks
 saving the profile (#335)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The Membership tab refused to save anything — school, major, skills, interests,
socials — unless a graduation year had been typed in, and the error it showed
("That graduation year does not look right") pointed at a field the member had
deliberately left empty.

The guard compared against `undefined` while the value is `null` for a blank
field: `null !== undefined` is true and `Number.isInteger(null)` is false, so
every save with an empty year fell into the error branch. `null` is the value
that CLEARS the column, so it has to pass.

Introduced by the review fix on #323, which changed the payload from
`undefined` to `null` to make fields clearable and did not move the guard with
it. Found while auditing the product against MVP.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
---
 sites/mainweb/components/portal/MembershipTab.tsx | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sites/mainweb/components/portal/MembershipTab.tsx b/sites/mainweb/components/portal/MembershipTab.tsx
index e18f5a1c..9940a6d5 100644
--- a/sites/mainweb/components/portal/MembershipTab.tsx
+++ b/sites/mainweb/components/portal/MembershipTab.tsx
@@ -82,10 +82,14 @@ export function MembershipTab() {
   const save = () => {
     setError(null);
 
+    // `null` is a graduation year that was left blank, which is allowed and is
+    // what clears the column. The guard compared against `undefined` instead,
+    // so `Number.isInteger(null)` failed it and the whole form refused to save
+    // — school, skills, socials and all — until a year was typed in.
     const year = form.graduationYear.trim()
       ? Number(form.graduationYear)
       : null;
-    if (year !== undefined && !Number.isInteger(year)) {
+    if (year !== null && !Number.isInteger(year)) {
       setError("That graduation year does not look right.");
       return;
     }