Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the support of Circle geometry in SQL interface #245

Closed
jiayuasu opened this issue Jun 20, 2018 · 3 comments

Comments

@jiayuasu
Copy link
Member

commented Jun 20, 2018

Actual behavior

Circle object is not a standard type in common geospatial data format. In GeoSpark, it is mainly used to help distance join. The radius of the circles serve as the buffer.

This actually leads to lots of confusion when GeoSpark users want to convert it back to the normal geometry. Will use ST_Buffer or ST_DWithin to solve this issue in the next release.

Settings

GeoSpark version = All till 1.1.3

Apache Spark version = all

JRE version = all

API type = SQL in Scala and Java

@pedromorfeu

This comment has been minimized.

Copy link

commented Jan 27, 2019

@jiayuasu, is it safe, tough, to use Circle, CirceRDD and ST_Circle in 1.1.3?
For instance, I'm noticing that, in a join query circle/point, points that fall in the boundary of a circle aren't considered to be intersecting/contained.

@jiayuasu

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2019

@pedromorfeu

This comment has been minimized.

Copy link

commented Jan 28, 2019

@jiayuasu, looks like distance join isn't considering points that fall in boundary of the circle. However, PostGIS does consider them. Example:

select ST_within(
	cast(ST_SetSRID(ST_GeomFromText('POINT (1.0436518037 41.6345011605)')::geography,4326) as geometry), 
	cast(st_buffer(ST_SetSRID(ST_GeomFromText('POINT (1.04125843698 41.6345227856)')::geography,4326), 200::float) as geometry)
)

Result: true

Well, it can be related to the projection PostGIS is doing. I'm using projection EPSG:3035 for Spain.

@jiayuasu jiayuasu closed this Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.