Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two bugs: (1) RDD API forgets to support WKB format. (2) toString() bug #216

Merged
merged 1 commit into from Apr 17, 2018

Conversation

@jiayuasu
Copy link
Member

commented Apr 17, 2018

Is this PR related to a proposed Issue?

This PR solves Issue #213 and #214

What changes were proposed in this PR?

  1. Add a catch logic in SpatialRDD format mapper to handle WKB input for GeoSpark-core RDD API
  2. Add a data parser in SpatialRDD format mapper to extract duplicated geometry string. Now if print a geometry object, the toString() method in each geometry in SpatialRDD will automatically compose a WKT format string with all other attributes appended.

How was this patch tested?

This PR has passed the regression test. This PR introduces several new unit tests to guarantee the correctness of toString() method result

Did this PR include necessary documentation updates?

This PR doesn't affect any public APIs.

Fix two bugs: (1) RDD API forgets to support WKB format. (2) Geometry…
… loaded from all sources (except shapefiles) will duplicate the input geometry when the toString() method is called.

@jiayuasu jiayuasu merged commit 2bfa28e into DataSystemsLab:master Apr 17, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
jiayuasu added a commit that referenced this pull request Apr 17, 2018
Fix two bugs: (1) RDD API forgets to support WKB format. (2) Geometry…
… loaded from all sources (except shapefiles) will duplicate the input geometry when the toString() method is called. (#216)
jiayuasu added a commit that referenced this pull request Apr 17, 2018
Fix two bugs: (1) RDD API forgets to support WKB format. (2) Geometry…
… loaded from all sources (except shapefiles) will duplicate the input geometry when the toString() method is called. (#216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.