Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the cumulative non-spatial attributes issue #223

Merged
merged 3 commits into from Apr 26, 2018

Conversation

@jiayuasu
Copy link
Member

commented Apr 26, 2018

Is this PR related to a proposed Issue?

See Issue #222

What changes were proposed in this PR?

  1. Fix the cumulative non-spatial attributes issue and improve the related unit tests. Since a format mapper instance is used for a entire partition, we need to clear the attribute before parsing the input line.

  2. Improve the redundant format mapper issue.

How was this patch tested?

Passed the regression test and improved the unit test.
Reduce the test data size to speed up the test.

Did this PR include necessary documentation updates?

Not affect public APIs.

Fix the issue that UserData field of a Geometry has cumulative non-sp…
…atial attributes. Refine the internal logic of FormatMapper and remove redundant code.

@jiayuasu jiayuasu added this to the 1.2.0 milestone Apr 26, 2018

@jiayuasu jiayuasu modified the milestones: 1.2.0, 1.1.3 Apr 26, 2018

@jiayuasu jiayuasu merged commit 47f414b into DataSystemsLab:master Apr 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
jiayuasu added a commit that referenced this pull request Apr 26, 2018
Fix the cumulative non-spatial attributes issue (#223)
* Fix the issue that UserData field of a Geometry has cumulative non-spatial attributes. Refine the internal logic of FormatMapper and remove redundant code.

* Fix the error in core scala test

* Reduce the unit test data to make the test faster
jiayuasu added a commit that referenced this pull request Apr 26, 2018
Fix the cumulative non-spatial attributes issue (#223)
* Fix the issue that UserData field of a Geometry has cumulative non-spatial attributes. Refine the internal logic of FormatMapper and remove redundant code.

* Fix the error in core scala test

* Reduce the unit test data to make the test faster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.