Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix in Adapter.toDF when creating a DataFrame from a ShapeFile #331

Merged
merged 3 commits into from Feb 21, 2019

Conversation

@Serhuela
Copy link
Contributor

commented Feb 21, 2019

Is this PR related to a proposed Issue?

No.

What changes were proposed in this PR?

When using Adapter.toDF in order to create a DataFrame from a shapeFile, a bug can occur. If the *.dbf has at least one row with the last field empty, the bug will occur.
The problem is the default behaviour of scala's split function; it trims trailing empty fields.

How was this patch tested?

A new unitary test called "Read shapefileWithMissing -> DataFrame" has been created on file "adapterTestScala.scala". A specific ShapeFile has been created to spot the bug.

Did this PR include necessary documentation updates?

Not sure. Maybe not.

@jiayuasu jiayuasu added this to the 1.2.0 milestone Feb 21, 2019

@jiayuasu

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

@Serhuela Thanks for your contribution!

@jiayuasu jiayuasu merged commit dbd5f88 into DataSystemsLab:master Feb 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.