Permalink
Browse files

Fix: In _fnExtend there was a bug where a variable referenced a 'loca…

…lly global' (for lack of a better term) variable rather than the in function variable that it should be have. Got away with this since _fnExtend is only used for one thing at the moment, but it was wrong. Now fixed.

Update - Performance / Memory: The functions that DataTables uses are not instance based, they are locally scoped, but they were included in the DataTable constructore, which meant that every time you create a new 'instance' of DataTables ($().dataTable()) it would create these functions in that scope again and again. That's completely pointless since we only need them once, so moving them outside the constructor helps both performance and memory (not huge, but very little helps!).
  • Loading branch information...
1 parent ec10497 commit ab454c1c335eeb9e83353eb87fbc84482af2274d @DataTables committed Oct 7, 2012
Showing with 4,072 additions and 4,074 deletions.
  1. +4,056 −4,057 media/js/jquery.dataTables.js
  2. +15 −16 media/src/DataTables.js
  3. +1 −1 media/src/core/core.support.js
Oops, something went wrong.

0 comments on commit ab454c1

Please sign in to comment.