Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Update media/js/jquery.dataTables.js #131

Closed
wants to merge 1 commit into from

2 participants

@boh1996

Changed the event selector to make it easier to make live changes

@boh1996 boh1996 Update media/js/jquery.dataTables.js
Changed the event selector to make it easier to make live changes
a727618
@DataTables
Owner

Thanks for the pull request.

$().live() is deprecated and removed in jQuery 1.9, so I'm not going to include this patch directly. Possibly it is a good idea for DataTables to use delegated events for its controls in future, although I'm planning on making DataTables a lot more modular in future, so a different filtering display plug-in might be the way to customise these things, rather than writing different HTML on top of what DataTables initialised.

@DataTables DataTables closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 26, 2012
  1. @boh1996

    Update media/js/jquery.dataTables.js

    boh1996 authored
    Changed the event selector to make it easier to make live changes
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  media/js/jquery.dataTables.js
View
2  media/js/jquery.dataTables.js
@@ -2652,7 +2652,7 @@
*/
$('select option[value="'+oSettings._iDisplayLength+'"]', nLength).attr("selected", true);
- $('select', nLength).bind( 'change.DT', function(e) {
+ $('[name="'+oSettings.sTableId+'_length"]').live( 'change.DT', function(e) {
var iVal = $(this).val();
/* Update all other length options for the new display */
Something went wrong with that request. Please try again.