New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean LatLongValue #156

Merged
merged 7 commits into from Oct 8, 2018

Conversation

3 participants
@JeroenDeDauw
Member

JeroenDeDauw commented Oct 3, 2018

Includes new tests which are a step towards no longer inheriting from DataValueTest

@codecov-io

This comment has been minimized.

codecov-io commented Oct 3, 2018

Codecov Report

Merging #156 into master will decrease coverage by 0.56%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #156      +/-   ##
============================================
- Coverage     92.85%   92.29%   -0.57%     
- Complexity      222      231       +9     
============================================
  Files            12       12              
  Lines           658      675      +17     
============================================
+ Hits            611      623      +12     
- Misses           47       52       +5
Impacted Files Coverage Δ Complexity Δ
src/Values/LatLongValue.php 79.24% <66.66%> (-4.09%) 26 <6> (+9)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 402f488...bc7d27e. Read the comment docs.

@JeroenDeDauw JeroenDeDauw requested a review from addshore Oct 8, 2018

@addshore addshore merged commit cbb2876 into master Oct 8, 2018

3 checks passed

Scrutinizer 10 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@JeroenDeDauw JeroenDeDauw deleted the latlng branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment