Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add support for multiple migration storage names #148

Merged
merged 1 commit into from Sep 10, 2012

Conversation

Projects
None yet
2 participants
Contributor

kamui commented Sep 10, 2012

Related to #125, hopefully fixes it.

Contributor

bmabey commented Sep 10, 2012

It says the PR can't be automatically merged (so travis won't fire off a build)... you'll need to rebase and then push again I think.

Contributor

bmabey commented Sep 10, 2012

It probably isn't a clean merge due to the fact that I had to revert your other commit. I'd rebase to master and then squash all the commits needed to make this work into a single one.

bmabey added a commit that referenced this pull request Sep 10, 2012

Merge pull request #148 from kamui/sequel_transaction
Add support for multiple migration storage names

@bmabey bmabey merged commit 627c5b8 into DatabaseCleaner:master Sep 10, 2012

1 check passed

default The Travis build passed
Details
Contributor

bmabey commented Sep 10, 2012

Travis is green, so I merged it in back in. Thanks for the touch-up work.

Contributor

kamui commented Sep 10, 2012

Thanks, I hope that actually worked. It's difficult not being able to run specs against my changes.

Couldn't this just be @tables_to_exclude += migration_storage_names ?

Owner

kamui replied Sep 10, 2012

Oh that's true. You can cherry pick my commit 8aa2fec or just modify it in your repo.

Cherry-picked it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment