Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use correct SQLite3Adapter superclass in Rails 4 #153

Merged
merged 1 commit into from Feb 15, 2013

Conversation

Projects
None yet
7 participants
Contributor

scottwillson commented Oct 16, 2012

Hi there.

I'm using Database Cleaner in a Rails 4 (edge) project, and the current master fails with:

.../database_cleaner-0.9.1/lib/database_cleaner/active_record/truncation.rb:200:in `module:ConnectionAdapters': superclass mismatch for class SQLite3Adapter (TypeError)

Looks like the SQLite3Adapter superclass changed in Rails 4. This commit checks the superclass in truncation.rb and should preserver Rails 3 compatibility.

pahnin commented Jan 20, 2013

I too have this problem, is there anyway fixing this?
Like a temporary fix? I'm not using mysql anyway!

parndt commented Feb 14, 2013

I too have this issue and this pull request works for me.

@bmabey I suggest you look into merging this :)

bmabey added a commit that referenced this pull request Feb 15, 2013

Merge pull request #153 from scottwillson/master
Use correct SQLite3Adapter superclass in Rails 4

@bmabey bmabey merged commit 9f898fc into DatabaseCleaner:master Feb 15, 2013

1 check failed

default The Travis build failed
Details
Contributor

bmabey commented Feb 15, 2013

Merged in, sorry for the delay. Thanks @scottwillson for the patch!

Contributor

scottwillson commented Feb 15, 2013

Thanks for database cleaner, Ben!

On Feb 14, 2013, at 6:23 PM, Ben Mabey notifications@github.com wrote:

Merged in, sorry for the delay. Thanks @scottwillson for the patch!


Reply to this email directly or view it on GitHub.

grosser commented Apr 24, 2013

an official release would be nice, had to dig through google to this issue and now using 1.0.0.RC1

I've been fighting with this too.. just found this issue. An official release for Rails 4 or at least a pointer to the proper branch would help :)

Contributor

bmabey commented May 13, 2013

Push pushed v1.0.0.

Wow! Thanks @bmabey - that was quick :)

Contributor

bmabey commented May 14, 2013

Heh, or late depending on your point of view. :) A lot of things were in motion but hopefully this will be a stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment