README, suggest append_after to ensure proper order of cleanup #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrochkind Good point! Could you fix the conflict and update this PR? After that I'd be happy to merge this. |
It's best to have DatabaseCleaner.clean run AFTER capybara cleanup, in case capybara cleanup ends up triggering anything that could be interrupted by the database cleaner. `require 'capybara/rspec'` installs an after hook for Capybara cleanup. rspec after hooks are run in _reverse_ order of definition, after hooks defined last are run first. So with `require 'capybara/rspec'` at top of file, and then later manually defining an after hook for DC cleanup... DC cleanup fires before capybara's cleanup. Using RSpec's `append_after` instead of `after` fixes this. With so many timing issues that can go wrong with capybara, might as well eliminate one more potential one.
|
done |
|
@jrochkind wonderful, thanks! 👍 |
etagwerker
added a commit
that referenced
this pull request
Jan 15, 2016
README, suggest append_after to ensure proper order of cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's best to have DatabaseCleaner.clean run AFTER capybara cleanup, in case capybara cleanup ends up triggering anything that could be interrupted by the database cleaner.
require 'capybara/rspec'installs an after hook for Capybara cleanup.rspec after hooks are run in reverse order of definition, after hooks defined last are run first. So with
require 'capybara/rspec'at top of file, and then later manually defining an after hook for DC cleanup... DC cleanup fires before capybara's cleanup.Using RSpec's
append_afterinstead ofafterfixes this. With so many timing issues that can go wrong with capybara, might as well eliminate one more potential one.