Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom log for context #33

Merged
merged 2 commits into from Nov 22, 2016
Merged

add custom log for context #33

merged 2 commits into from Nov 22, 2016

Conversation

upccup
Copy link
Contributor

@upccup upccup commented Nov 21, 2016

No description provided.

@codecov-io
Copy link

Current coverage is 64.44% (diff: 100%)

Merging #33 into master will increase coverage by 0.01%

@@             master        #33   diff @@
==========================================
  Files            23         24     +1   
  Lines          1670       1696    +26   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1076       1093    +17   
- Misses          480        489     +9   
  Partials        114        114          

Powered by Codecov. Last update f8f6310...7c1d048

@gorilla001
Copy link

@upccup 这是干嘛的

@upccup
Copy link
Contributor Author

upccup commented Nov 22, 2016

@pwzgorilla To define this locally to a package to get package tagged log messages.

I will use it in the following commit.

@gorilla001
Copy link

@upccup 那为啥不跟following commit一起提交?还是说先不用管这个pr?

@upccup
Copy link
Contributor Author

upccup commented Nov 22, 2016

@pwzgorilla Is a single module. if no error need merge.

@gorilla001
Copy link

@upccup 这两个提交是相关的吗?是的话先rebase。

@upccup
Copy link
Contributor Author

upccup commented Nov 22, 2016

one commit is custom code and another is add 3rd pkgs .

@upccup
Copy link
Contributor Author

upccup commented Nov 22, 2016

@pwzgorilla @cmingxu any other question?

@gorilla001
Copy link

@upccup 那你就merge了吧,虽然看不懂你要干嘛。

@upccup upccup merged commit d390209 into Dataman-Cloud:master Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants