New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace x-terminal-emulator with xdg-terminal #201

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@jubalh
Contributor

jubalh commented Aug 3, 2015

x-terminal-emulator is working only on debian and derivates AFAIK. I
think xdg-open is the correct thing to use here since it behaves the
same across all distros.

However I am not 100% sure if my change is correct. Please test it too.

Replace x-terminal-emulator with xdg-terminal
x-terminal-emulator is working only on debian and derivates AFAIK. I
think xdg-open is the correct thing to use here since it behaves the
same across all distros.
@DaveDavenport

This comment has been minimized.

Show comment
Hide comment
@DaveDavenport

DaveDavenport Aug 3, 2015

Owner

xdg-terminal does not exist on my system, or is available in a package.

Owner

DaveDavenport commented Aug 3, 2015

xdg-terminal does not exist on my system, or is available in a package.

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Aug 3, 2015

Contributor

And what system is that @DaveDavenport ?

Contributor

jubalh commented Aug 3, 2015

And what system is that @DaveDavenport ?

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Aug 3, 2015

Contributor

Also this seems to indicate to try to xdg-termianl first:
http://unix.stackexchange.com/questions/137782/launching-a-terminal-emulator-without-knowing-which-ones-are-installed

AFAIK it should be the distribution unspecific way of launching the default terminal.
x-terminal-emulator will only work on debian based ones AFAIK.

Contributor

jubalh commented Aug 3, 2015

Also this seems to indicate to try to xdg-termianl first:
http://unix.stackexchange.com/questions/137782/launching-a-terminal-emulator-without-knowing-which-ones-are-installed

AFAIK it should be the distribution unspecific way of launching the default terminal.
x-terminal-emulator will only work on debian based ones AFAIK.

@carnager

This comment has been minimized.

Show comment
Hide comment
@carnager

carnager Aug 3, 2015

Collaborator

@jubalh there is no distribution agnostic way to call a terminal. x-terminal-emulator only works on debian. Maybe on fedora too, I don't know. And as for xdg-terminal... I haven't found any major distribution that ships with it. Fedora doesn't. Ubuntu/Debian don't. Arch Linux: doesn't.

Apart from that: these are just defaults. It's easy to set your own commands via command line or .Xresources

Collaborator

carnager commented Aug 3, 2015

@jubalh there is no distribution agnostic way to call a terminal. x-terminal-emulator only works on debian. Maybe on fedora too, I don't know. And as for xdg-terminal... I haven't found any major distribution that ships with it. Fedora doesn't. Ubuntu/Debian don't. Arch Linux: doesn't.

Apart from that: these are just defaults. It's easy to set your own commands via command line or .Xresources

@DaveDavenport

This comment has been minimized.

Show comment
Hide comment
@DaveDavenport

DaveDavenport Aug 3, 2015

Owner

I do not seem to have it on debian, apt-file does not find it in any package.
According to @carnager it also does not exists on archlinux and fedora.

maybe the distro's packages should update the default in rofi, I could make it a configure option.
I don't realy see it as rofi's task to figure this out. (we could provide a script that does the what the stackexchange page suggest?)

Owner

DaveDavenport commented Aug 3, 2015

I do not seem to have it on debian, apt-file does not find it in any package.
According to @carnager it also does not exists on archlinux and fedora.

maybe the distro's packages should update the default in rofi, I could make it a configure option.
I don't realy see it as rofi's task to figure this out. (we could provide a script that does the what the stackexchange page suggest?)

@DaveDavenport

This comment has been minimized.

Show comment
Hide comment
@DaveDavenport

DaveDavenport Aug 3, 2015

Owner

I went with the i3 method, rofi now includes a rofi-sensible-terminal script that tries xdg-terminal, x-terminal-emulator and several others.

Owner

DaveDavenport commented Aug 3, 2015

I went with the i3 method, rofi now includes a rofi-sensible-terminal script that tries xdg-terminal, x-terminal-emulator and several others.

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Aug 4, 2015

Contributor

@DaveDavenport This is a great solution, thanks a lot!
With commits da044e0 and 7e9ac52 I can continue packaging rofi.

Just one more question: Will there be a new release soon? Otherwise I will have to create patches to include those two commits.

Contributor

jubalh commented Aug 4, 2015

@DaveDavenport This is a great solution, thanks a lot!
With commits da044e0 and 7e9ac52 I can continue packaging rofi.

Just one more question: Will there be a new release soon? Otherwise I will have to create patches to include those two commits.

@jubalh jubalh closed this Aug 4, 2015

@DaveDavenport

This comment has been minimized.

Show comment
Hide comment
@DaveDavenport

DaveDavenport Aug 4, 2015

Owner

New release after my holiday. So end of august.

Owner

DaveDavenport commented Aug 4, 2015

New release after my holiday. So end of august.

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Aug 4, 2015

Contributor

Alright

Contributor

jubalh commented Aug 4, 2015

Alright

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Aug 4, 2015

Contributor

Unfortunately there is some mistake in commit da044e0
I created a comment there. xdg-terminal does not support the -e option.

Contributor

jubalh commented Aug 4, 2015

Unfortunately there is some mistake in commit da044e0
I created a comment there. xdg-terminal does not support the -e option.

@DaveDavenport

This comment has been minimized.

Show comment
Hide comment
@DaveDavenport

DaveDavenport Aug 4, 2015

Owner

aah F!#!@# stupid incompatibility.

Owner

DaveDavenport commented Aug 4, 2015

aah F!#!@# stupid incompatibility.

@DaveDavenport DaveDavenport reopened this Aug 4, 2015

@DaveDavenport

This comment has been minimized.

Show comment
Hide comment
@DaveDavenport

DaveDavenport Aug 4, 2015

Owner

Ill remove xdg-terminal for now.. it seems not to be in http://portland.freedesktop.org/xdg-utils-1.0/ and not in the upcoming 1.1 release.

the option is configurable for a reason.

Owner

DaveDavenport commented Aug 4, 2015

Ill remove xdg-terminal for now.. it seems not to be in http://portland.freedesktop.org/xdg-utils-1.0/ and not in the upcoming 1.1 release.

the option is configurable for a reason.

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Aug 4, 2015

Contributor

I will contact the authors and freedesktop to find out more.

Contributor

jubalh commented Aug 4, 2015

I will contact the authors and freedesktop to find out more.

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Aug 17, 2015

Contributor

No response from them yet.
On your distribution you probably have to install xdg-utils to have xdg-open. Also I found other projects use it, for example: https://github.com/thestinger/termite/

Contributor

jubalh commented Aug 17, 2015

No response from them yet.
On your distribution you probably have to install xdg-utils to have xdg-open. Also I found other projects use it, for example: https://github.com/thestinger/termite/

@DaveDavenport

This comment has been minimized.

Show comment
Hide comment
@DaveDavenport

DaveDavenport Nov 1, 2015

Owner

We have a rofi-sensible-terminal now.

Owner

DaveDavenport commented Nov 1, 2015

We have a rofi-sensible-terminal now.

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Nov 1, 2015

Contributor

Which still just opens the first terminal from a list it can find. Compared to xdg-terminal which tries to open the most suitable terminal for the environment. So when you are on XFCE xdg-terminal opens xfce4-terminal. On KDE it opens konsole.

Contributor

jubalh commented Nov 1, 2015

Which still just opens the first terminal from a list it can find. Compared to xdg-terminal which tries to open the most suitable terminal for the environment. So when you are on XFCE xdg-terminal opens xfce4-terminal. On KDE it opens konsole.

@DaveDavenport

This comment has been minimized.

Show comment
Hide comment
@DaveDavenport

DaveDavenport Nov 1, 2015

Owner

Yes, issue stays.. maybe make a merge request that adds xdg-terminal as first in list of rofi-sensible-terminal

Owner

DaveDavenport commented Nov 1, 2015

Yes, issue stays.. maybe make a merge request that adds xdg-terminal as first in list of rofi-sensible-terminal

@DaveDavenport

This comment has been minimized.

Show comment
Hide comment
@DaveDavenport

DaveDavenport Nov 1, 2015

Owner

let me fix that

Owner

DaveDavenport commented Nov 1, 2015

let me fix that

@DaveDavenport

This comment has been minimized.

Show comment
Hide comment
@DaveDavenport
Owner

DaveDavenport commented Nov 1, 2015

done

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Nov 17, 2015

Contributor

Just for reference:
It was added with commit d01afc5

Contributor

jubalh commented Nov 17, 2015

Just for reference:
It was added with commit d01afc5

@jubalh jubalh referenced this pull request Mar 7, 2016

Closed

wrong xdg-terminal call #355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment