Add support for PHP 8.4.* #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Require: vimeo/psalm#10928 |
Owner
|
@mkoprek Thanks for your help with this PR. Really appreciate your help on it. Given this project only contains attributes, I wonder if having both PHPStan and Psalm is overkill? Options I see:
The benefit of the first option is the phpstan rules for this can be upgraded for 8.4. Have you any thoughts on the above, or a better suggestion? |
Author
|
Hey, From mine personal perspective I think using both tools is an overkill. I would choose option one, I will push code with changes for it. Thanks for fast response :) |
DaveLiddament
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.