feat: launch on Windows startup#10
Closed
KristianP26 wants to merge 3 commits into
Closed
Conversation
Add set_autostart / is_autostart_enabled backed by the per-user HKCU Run key (winreg, zero deps, lazily imported so the module still imports off Windows). AppConfig gains an `autostart` field; load_config reconciles it from the registry, which is the source of truth. New AppError.AUTOSTART_FAILED surfaces registry write failures. Cross-platform tests mock the registry.
General-tab checkbox bound to AppConfig.autostart. The registry side effect is applied where the user commits changes (Apply and OK) via a small helper, with a warning dialog on failure — kept out of save_config so plain setting writes stay registry-free.
Add the config.py autostart contract to IMPLEMENTATION.md, note the feature in the README, and check in the implementation plan.
Contributor
Author
|
Closing — autostart already landed in main via src/startup.py (pythonw-based, more complete). This PR duplicates it. |
DavidHruby1
added a commit
that referenced
this pull request
Jun 4, 2026
feat: recording snackbar indicator (#10)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an opt-in "Start with Windows" toggle in the Settings dialog (General tab). When enabled, Screamer launches automatically at login.
How
HKCU\Software\Microsoft\Windows\CurrentVersion\Runkey.winreg(stdlib, zero new deps), lazily imported soconfig.pystill imports cleanly off Windows.load_config()reconciles theautostartfield from the actual registry state, so the checkbox always reflects reality.save_config— plain setting writes (e.g. tray toggles) stay registry-free. Failures surface as a warning dialog (AppError.AUTOSTART_FAILED).python -m src.main(documented limitation).API additions (
config.py)set_autostart(enabled: bool) -> Noneis_autostart_enabled() -> boolAppConfig.autostart: boolBoth documented in
docs/IMPLEMENTATION.md.Tests
5 cross-platform tests in
tests/test_config.py(registry mocked): default off, non-Windows no-op/False, and the frozen-vs-dev command. Full suite passes (34 tests). Verified the real HKCU enable→query→disable roundtrip on Windows.Commits
feat(config)— registry helpers,AppConfig.autostart,load_configreconcile,AUTOSTART_FAILED, testsfeat(settings)— General-tab checkbox + apply on Apply/OKdocs— IMPLEMENTATION.md contract, README, implementation plan