Become rubocop clean

Author: DavidS

.rubocop.yml

@@ -0,0 +1,20 @@
+AllCops:
+  RunRailsCops: true
+  Include:
+    - '**/Rakefile'
+    - '**/config.ru'
+  Exclude:
+    - 'bin/**/*'
+    - 'config/**/*'
+    - 'db/**/*'
+    - 'script/**/*'
+    - 'spec/**/*'
+
+Style/LineLength:
+  Max: 100
+
+# Hubris, one of the Three Great Virtues
+# http://c2.com/cgi/wiki?LazinessImpatienceHubris
+Rails/HasAndBelongsToMany:
+  Enabled: false
+

app/controllers/application_controller.rb

@@ -1,9 +1,12 @@
+# Functionality for all controllers:
+#   * forgery protection
+#   * default not_authenticated action
 class ApplicationController < ActionController::Base
   # Prevent CSRF attacks by raising an exception.
   # For APIs, you may want to use :null_session instead.
   protect_from_forgery with: :exception
 
   def not_authenticated
-    redirect_to login_url, :alert => "First login to access this page."
+    redirect_to login_url, alert: 'First login to access this page.'
   end
 end

app/controllers/people_controller.rb

@@ -1,3 +1,4 @@
+# The main controller for people
 class PeopleController < ApplicationController
   include DefaultResponses
   include DefaultSearch
@@ -50,13 +51,21 @@ def destroy
   end
 
   private
-    # Use callbacks to share common setup or constraints between actions.
-    def set_person
-      @person = Person.find(params[:id])
-    end
-
-    # Never trust parameters from the scary internet, only allow the white list through.
-    def person_params
-      params.require(:person).permit(:login, :email, :password, :password_confirmation, :first_name, :middle_name, :last_name, :ssn, :birthdate, :address_line_1, :address_line_2, :address_line_3, :telephone_mobile, :telephone_office, :telephone_private, :personnel_number, :first_work_day, :working_hours_total, :working_hours_per_day, :holidays, :holidays_left, :hours, :overtime_hours, :job_description, :internal_notes)
-    end
+
+  # Use callbacks to share common setup or constraints between actions.
+  def set_person
+    @person = Person.find(params[:id])
+  end
+
+  # Never trust parameters from the scary internet, only allow the white listed
+  # through.
+  def person_params
+    params.require(:person).permit(
+      :login, :email, :password, :password_confirmation, :first_name,
+      :middle_name, :last_name, :ssn, :birthdate, :address_line_1,
+      :address_line_2, :address_line_3, :telephone_mobile, :telephone_office,
+      :telephone_private, :personnel_number, :first_work_day,
+      :working_hours_total, :working_hours_per_day, :holidays, :holidays_left,
+      :hours, :overtime_hours, :job_description, :internal_notes)
+  end
 end

app/controllers/projects_controller.rb

@@ -1,3 +1,4 @@
+# The main controller for projects
 class ProjectsController < ApplicationController
   include DefaultResponses
   include DefaultSearch
@@ -21,7 +22,11 @@ def auto_complete_people_search
   # GET /projects/1
   # GET /projects/1.json
   def show
-    @searched_people = params.has_key?(:people_search) ? Person.search_for(params[:people_search], :order => params[:people_order]) : []
+    if params.key?(:people_search)
+      @searched_people = Person.search_for(params[:people_search], order: params[:people_order])
+    else
+      @searched_people = []
+    end
   end
 
   def add_person
@@ -59,13 +64,15 @@ def destroy
   end
 
   private
-    # Use callbacks to share common setup or constraints between actions.
-    def set_project
-      @project = Project.find(params[:id])
-    end
 
-    # Never trust parameters from the scary internet, only allow the white list through.
-    def project_params
-      params.require(:project).permit(:name)
-    end
+  # Use callbacks to share common setup or constraints between actions.
+  def set_project
+    @project = Project.find(params[:id])
+  end
+
+  # Never trust parameters from the scary internet, only allow the white listed
+  # through.
+  def project_params
+    params.require(:project).permit(:name)
+  end
 end

app/controllers/sessions_controller.rb

@@ -1,18 +1,17 @@
+# Manage logged in users
 class SessionsController < ApplicationController
-
   def create
     user = login(params[:email], params[:password], params[:remember_me])
     if user
-      redirect_back_or_to root_url, :notice => "Logged in!"
+      redirect_back_or_to root_url, notice: 'Logged in!'
     else
-      flash.now.alert = "Email or password was invalid"
+      flash.now.alert = 'Email or password was invalid!'
       render :new
     end
   end
 
   def destroy
     logout
-    redirect_to root_url, :notice => "Logged out!"
+    redirect_to root_url, notice: 'Logged out!'
   end
-
 end

app/controllers/welcome_controller.rb

@@ -1,5 +1,7 @@
+# Homepage
 class WelcomeController < ApplicationController
-  #before_filter :require_login, :only => :index
+  # No login required here
+  # before_filter :require_login, :only => :index
 
   def index
   end

app/helpers/application_helper.rb

@@ -1,2 +1,3 @@
+# Nothing to see here
 module ApplicationHelper
 end

app/helpers/people_helper.rb

@@ -1,2 +1,3 @@
+# Nothing to see here
 module PeopleHelper
 end

app/helpers/projects_helper.rb

@@ -1,2 +1,3 @@
+# Nothing to see here
 module ProjectsHelper
 end

app/helpers/sessions_helper.rb

@@ -1,2 +1,3 @@
+# Nothing to see here
 module SessionsHelper
 end