controllers: Pull the scoped_search concern out

This fixes the last complaint of codeclimate about those controllers.

Author: DavidS

app/controllers/concerns/default_search.rb

@@ -0,0 +1,18 @@
+# everything concerning the scoped_search implementation
+module DefaultSearch
+  def default_index(klass, params)
+    klass.search_for(params[:search], order: params[:order])
+  rescue => e
+    flash[:error] = e.to_s
+    klass.search_for ''
+  end
+
+  def auto_complete_search_impl(klass, search_params)
+    begin
+      @items = klass.complete_for(search_params)
+    rescue ScopedSearch::QueryNotSupported => e
+      @items = [{ error: e.to_s }]
+    end
+    render json: @items
+  end
+end

app/controllers/people_controller.rb

@@ -1,24 +1,17 @@
 class PeopleController < ApplicationController
   include DefaultResponses
+  include DefaultSearch
 
   before_action :set_person, only: [:show, :edit, :update, :destroy]
 
   # GET /people
   # GET /people.json
   def index
-    @people = Person.search_for(params[:search], :order => params[:order])
-  rescue => e
-    flash[:error] = e.to_s
-    @people = Person.search_for ''
+    @people = default_index(Person, params)
   end
 
   def auto_complete_search
-    begin
-      @items = Person.complete_for(params[:search])
-    rescue ScopedSearch::QueryNotSupported => e
-      @items = [{:error =>e.to_s}]
-    end
-    render :json => @items
+    auto_complete_search_impl(Person, params[:search])
   end
 
   # GET /people/1

app/controllers/projects_controller.rb

@@ -1,33 +1,21 @@
 class ProjectsController < ApplicationController
   include DefaultResponses
+  include DefaultSearch
 
   before_action :set_project, only: [:show, :add_person, :edit, :update, :destroy]
 
   # GET /projects
   # GET /projects.json
   def index
-    @projects = Project.search_for(params[:search], :order => params[:order])
-  rescue => e
-    flash[:error] = e.to_s
-    @projects = Project.search_for ''
+    @projects = default_index(Project, params)
   end
 
   def auto_complete_search
-    begin
-      @items = Project.complete_for(params[:search])
-    rescue ScopedSearch::QueryNotSupported => e
-      @items = [{:error =>e.to_s}]
-    end
-    render :json => @items
+    auto_complete_search_impl(Project, params[:search])
   end
 
   def auto_complete_people_search
-    begin
-      @items = Person.complete_for(params[:people_search])
-    rescue ScopedSearch::QueryNotSupported => e
-      @items = [{:error =>e.to_s}]
-    end
-    render :json => @items
+    auto_complete_search_impl(Person, params[:people_search])
   end
 
   # GET /projects/1