Add protected-mode option to template config files #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defaults/main.yml:
* Add redis_protected_mode for redis server config
* Add redis_sentinel_protected_mode for redis sentinel config
templates/redis.conf.j2:
* Add redis_protected_mode variable for redis server config template
templates/redis_sentinel.conf.j2:
* Add redis_sentinel_protected_mode variable for redis sentinel
server config template
Signed-off-by: Tuan T. Pham <tuan@vt.edu>
Owner
|
Thanks! This closes #237 |
|
@DavidWittman you think you can merge this one soon, one less fork to manage |
rromanchuk
reviewed
Jun 22, 2020
defaults/main.yml
Outdated
| ## Redis sentinel configs | ||
| # Set this to true on a host to configure it as a Sentinel | ||
| redis_sentinel: false | ||
| redis_sentinel_protected_mode: yes |
defaults/main.yml: * Coerce value to string with double quote. Otherwise, .conf.j2 will write True CC: @rromanchuck Signed-off-by: Tuan T. Pham <tuan@vt.edu>
Owner
|
Thanks @rromanchuk and @neofob! |
Closed
rndmh3ro
pushed a commit
to telekom-mms/ansible-redis
that referenced
this pull request
Nov 27, 2020
* Add protected-mode option to template config files
defaults/main.yml:
* Add redis_protected_mode for redis server config
* Add redis_sentinel_protected_mode for redis sentinel config
templates/redis.conf.j2:
* Add redis_protected_mode variable for redis server config template
templates/redis_sentinel.conf.j2:
* Add redis_sentinel_protected_mode variable for redis sentinel
server config template
Signed-off-by: Tuan T. Pham <tuan@vt.edu>
* Update default setting to string
defaults/main.yml:
* Coerce value to string with double quote. Otherwise,
.conf.j2 will write True
CC: @rromanchuck
Signed-off-by: Tuan T. Pham <tuan@vt.edu>
|
protected mode was added in redis version 3.2, since there is no version check this will cause redis to fail with fatal config file error. In the future, it might be a good idea to version protect directives to maintain backwards compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaults/main.yml:
* Add redis_protected_mode for redis server config
* Add redis_sentinel_protected_mode for redis sentinel config
templates/redis.conf.j2:
* Add redis_protected_mode variable for redis server config template
templates/redis_sentinel.conf.j2:
* Add redis_sentinel_protected_mode variable for redis sentinel
server config template
Signed-off-by: Tuan T. Pham tuan@vt.edu