Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile entity textures 1.1 #11

Merged
merged 21 commits into from
Oct 11, 2018
Merged

Tile entity textures 1.1 #11

merged 21 commits into from
Oct 11, 2018

Conversation

Nexonus
Copy link
Contributor

@Nexonus Nexonus commented Sep 24, 2018

Steel alloyer:
steel_alloyer_side1
steel_alloyer_top
steel_alloyer_side2
steel_alloyer_front_on
steel_alloyer_front_off
steel_alloyer_bottom
Steel crusher:
steel_crusher_side2
steel_crusher_front_off
steel_crusher_top
steel_crusher_side1
steel_crusher_back
steel_crusher_bottom

@Davoleo Davoleo added enhancement Improvement to existing feature good first issue Good for newcomers Work in Progress labels Sep 24, 2018
@Davoleo Davoleo changed the title Steel Alloy Furnace Texture 1.1 Tile entity textures 1.1 Sep 24, 2018
@Davoleo
Copy link
Owner

Davoleo commented Sep 24, 2018

The pull request is ok, commit also the crusher textures to dav-branch when you have them ready,

for the other textures (blocks and items) do the same but on the 1.12.2 branch, I hope I explained myself well)

@Davoleo
Copy link
Owner

Davoleo commented Sep 24, 2018

I'll change the title to be more general, "Tile entity textures"

Copy link
Owner

@Davoleo Davoleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the texture name have to respect this conventions "name_name_side_on_off"
the name is not alloy furnace but "alloyer"

@Davoleo
Copy link
Owner

Davoleo commented Sep 25, 2018

Perfect, thanks

Copy link
Owner

@Davoleo Davoleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move new textures to the right directory, delete the old textures (Nexonus@665220f)

@Davoleo
Copy link
Owner

Davoleo commented Oct 10, 2018

I'm going to merge this pull request, but I need some changes before this happens see review ^
@Nexonus

@Davoleo Davoleo added the on hold AKA idle label Oct 10, 2018
@Davoleo
Copy link
Owner

Davoleo commented Oct 10, 2018

I already deleted the old ones for you but you need to move the new ones from the root directory to the right one

@Davoleo
Copy link
Owner

Davoleo commented Oct 11, 2018

Thanks, merging the PR

@Davoleo Davoleo merged commit b16f14e into Davoleo:dav-branch Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing feature good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants