Mail and Capybara are runtime requirements #11

Merged
merged 2 commits into from Nov 6, 2012

Conversation

Projects
None yet
2 participants
Contributor

ngauthier commented Nov 6, 2012

The gemspec only shows them as development dependencies. When I added it to a project, Mail was not defined, since it was not required yet by the project.

I've changed mail and capybara in the gemspec as well as requiring the libraries in the gem's source.

Tests pass and fixed my problem.

Contributor

bcardarella commented Nov 6, 2012

Can you version lock capybara to ~> 2.0

Master branch will be for Caybara 2 which requires some incompatible changes to how capybara-email works.

If you'd like to also submit a PR for 1-0-stable that has capybara version locked to ~> 1.0 I can do a gem release today (not sure which version you're using)

Contributor

ngauthier commented Nov 6, 2012

locked it to beta4. I'm running against capybara-email off my fork, which is fine for now. When capy goes 2.0 stable you can release capybara-email 2.0 stable. Fine for me.

bcardarella added a commit that referenced this pull request Nov 6, 2012

Merge pull request #11 from ngauthier/master
Mail and Capybara are runtime requirements

@bcardarella bcardarella merged commit 1d2401c into DavyJonesLocker:master Nov 6, 2012

1 check passed

default The Travis build passed
Details
Contributor

bcardarella commented Nov 6, 2012

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment