Password confirmation problem still happen after using the rails 4.0 confirmation validator patch #435

Closed
jerryshen opened this Issue Nov 12, 2012 · 6 comments

Comments

Projects
None yet
2 participants
@jerryshen

Hi

Based on this commit,

rails/rails@f975a86

I'v added the override to my initializer. but the problem still happen. the error message still displayed on the password firled not the confirmation field

Any ideas?

@bcardarella

This comment has been minimized.

Show comment Hide comment
@bcardarella

bcardarella Nov 12, 2012

Contributor

I am waiting on a pull request for Rails 4.0 that resolves this: rails/rails#8123

Feel free to +1 it

Contributor

bcardarella commented Nov 12, 2012

I am waiting on a pull request for Rails 4.0 that resolves this: rails/rails#8123

Feel free to +1 it

@jerryshen

This comment has been minimized.

Show comment Hide comment
@jerryshen

jerryshen Nov 12, 2012

Sorry, this file seems not work for me.
I'm using rails 3.2.8, does this supported 3.2.8?
https://github.com/bcardarella/rails/blob/d567c7daa9c74a29898f5abef6033cea2e51da5e/activemodel/lib/active_model/validations/confirmation.rb

When I focus out the confirmation field, nothing was triggered. I'm using the support for devise.

validates_confirmation_of :password

Is that possible to integrate your pull request to rails 3.2.8?

Sorry, this file seems not work for me.
I'm using rails 3.2.8, does this supported 3.2.8?
https://github.com/bcardarella/rails/blob/d567c7daa9c74a29898f5abef6033cea2e51da5e/activemodel/lib/active_model/validations/confirmation.rb

When I focus out the confirmation field, nothing was triggered. I'm using the support for devise.

validates_confirmation_of :password

Is that possible to integrate your pull request to rails 3.2.8?

@bcardarella

This comment has been minimized.

Show comment Hide comment
@bcardarella

bcardarella Nov 16, 2012

Contributor

This will not work in Rails 3.2 without some significant monkey patching. I have something working in an app, I will try to write a blog post

Contributor

bcardarella commented Nov 16, 2012

This will not work in Rails 3.2 without some significant monkey patching. I have something working in an app, I will try to write a blog post

@jerryshen

This comment has been minimized.

Show comment Hide comment
@jerryshen

jerryshen Nov 17, 2012

Thanks, @bcardarella please share your blog post after it's finished. I'm looking forward to take a look :)

Thanks, @bcardarella please share your blog post after it's finished. I'm looking forward to take a look :)

@jerryshen

This comment has been minimized.

Show comment Hide comment
@jerryshen

jerryshen Nov 23, 2012

@bcardarella if you can share it to me, that will be greatly appreciated

@bcardarella if you can share it to me, that will be greatly appreciated

@bcardarella

This comment has been minimized.

Show comment Hide comment
@bcardarella

bcardarella Nov 25, 2012

Contributor

@jerryshen I've packed it up into this gist: https://gist.github.com/4142149

You will need to define a new ConfirmationValidator on the model itself and set the error message in the locale file. Let me know if you have any issues.

Contributor

bcardarella commented Nov 25, 2012

@jerryshen I've packed it up into this gist: https://gist.github.com/4142149

You will need to define a new ConfirmationValidator on the model itself and set the error message in the locale file. Let me know if you have any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment