New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5.1 compatibility #696

Closed
tagliala opened this Issue Feb 24, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@tagliala
Copy link
Contributor

tagliala commented Feb 24, 2017

No description provided.

@tagliala tagliala self-assigned this Feb 24, 2017

tagliala added a commit that referenced this issue Feb 24, 2017

@tagliala

This comment has been minimized.

Copy link
Contributor Author

tagliala commented Feb 24, 2017

At the moment it works out of the box. I will not support form_with because form_for and form_tag are softly deprecated and will stay there until Rails 6.

Please use rails51 branch if you need Rails 5.1 compatibility. I will merge changes into master asap Rails 5.1 will be released

@tagliala tagliala added this to the 9.1.0 milestone Mar 7, 2017

@tagliala tagliala closed this in 4a3ebb3 Mar 7, 2017

@tagliala

This comment has been minimized.

Copy link
Contributor Author

tagliala commented Mar 7, 2017

Merged on the master branch

@klamath

This comment has been minimized.

Copy link

klamath commented May 29, 2017

@tagliala Hi! Can you please provide proof links for deprecation of form_with?
I thought that form_for & form_tag is softly deprecated. Now I'm totally confused (

@tagliala

This comment has been minimized.

Copy link
Contributor Author

tagliala commented May 29, 2017

@klamath sorry

Fixed my comment above:

I will not support form_with because form_for and form_tag are softly deprecated and will stay there until Rails 6.

@murdoch

This comment has been minimized.

Copy link

murdoch commented Oct 6, 2017

Would it be hard to support form_with? I reckon a lot of people will like it :) Maybe I'll try and do it myself.

@tagliala

This comment has been minimized.

Copy link
Contributor Author

tagliala commented Oct 6, 2017

@murdoch yes, please.

IIRC, I've skipped form_with because its implementation was not straightforward

A PR and a test case would be highly appreciated

@reckerswartz

This comment has been minimized.

Copy link

reckerswartz commented Oct 8, 2018

@tagliala does it still not support form_with?

@tagliala

This comment has been minimized.

Copy link
Contributor Author

tagliala commented Oct 8, 2018

@reckerswartz nope, sorry

PRs are welcomed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment