Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chars.json key/value data #6

Merged
merged 2 commits into from Aug 19, 2019

Conversation

@jeffpaul
Copy link
Contributor

commented Aug 8, 2019

If we're going to include a search feature (see #4), then we'll want to have as much data available in chars.json to support that. This PR works to add in missing entity, hex, and name data where feasible using data from https://unicode-table.com/en/.

jeffpaul added 2 commits Aug 8, 2019
@jeffpaul

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

@Dayjo I see that you've got these grouped as Misc, Math, Latin, and Arrows.

  1. Is there any intention to the spacing between lines? Was that a notation that you needed to add in missing characters?
  2. Were there any other groups intended besides the ones you've created? I see that https://unicode-table.com/en/sets/ has a couple options we could look at splitting out here as well.
@Dayjo

This comment has been minimized.

Copy link
Owner

commented Aug 9, 2019

@jeffpaul Hi, thanks for your suggestion, this is a great idea. I believe the original list was just taken from a site I found and I spent no time organizing it at all, definitely up for suggestions over better categorization and updating the list to be more in-depth.

@jeffpaul jeffpaul marked this pull request as ready for review Aug 10, 2019

@jeffpaul

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

@Dayjo cool, I'll look into proposing some groups and get your confirmation before working on a PR to shuffle anything around. Otherwise this PR should be good for your review.

@Dayjo Dayjo changed the base branch from master to release/v0.2.0 Aug 19, 2019

@Dayjo Dayjo merged commit f286831 into Dayjo:release/v0.2.0 Aug 19, 2019

@Dayjo Dayjo referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.