Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Package Health #624

Merged
merged 3 commits into from May 10, 2022
Merged

Improve Package Health #624

merged 3 commits into from May 10, 2022

Conversation

AdrianJSClark
Copy link
Member

@AdrianJSClark AdrianJSClark commented May 8, 2022

The changes here make some minor modifications that should improve the quality of the NuGet package output for DbUp and the various providers.

The changes are:

  • Combined common properties into a Directory.Build.props file so they do not need to be repeated
  • Configured for deterministic builds when constructed in CI
  • Added Source Link to enable debugging into the code by referencing the sources here on GitHub

Note: This PR depends on the yet-to-be-merged work from both #622 & #621 and if merged before those will include all their changes as well. Dependencies merged.

@AdrianJSClark AdrianJSClark requested a review from droyad May 8, 2022 07:24
@AdrianJSClark AdrianJSClark self-assigned this May 8, 2022
@droyad
Copy link
Member

droyad commented May 9, 2022

Combined common properties into a Directory.Build.props file so they do not need to be repeated

Won't we need to undo this when we pull them out into seperate repos? We'll either put them back into the csproj, or copy the Directory.Build.props just for the sake of the one csproj file per repo.

@droyad
Copy link
Member

droyad commented May 9, 2022

Sorry, I squash merged which I don't usually do, but there were some garbage commits in there.

Split common build properties out into a "Directory.Build.props" file to
avoid repetition across the project files.
Ensure that proper links back to the source code are able to be
generated and embedded on build. This allows people to debug by
referencing the source on GitHub, rather than needing to distribute a
sources package.
@AdrianJSClark
Copy link
Member Author

Sorry, I squash merged which I don't usually do, but there were some garbage commits in there.

😱 You monster!

All good, fixed up pretty easily.

Won't we need to undo this when we pull them out into seperate repos? We'll either put them back into the csproj, or copy the Directory.Build.props just for the sake of the one csproj file per repo.

I've found a Directory.Build.props file is handy to have even with only a couple of project files. Happy to reverse it if you think it clutters stuff up.

@droyad droyad merged commit d2455e9 into master May 10, 2022
@droyad droyad deleted the improve-package-health branch May 10, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants