Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperEQ distorts 24 bit output on raspbian armv7l #1986

Closed
eshchenko opened this issue Mar 12, 2018 · 8 comments

Comments

Projects
None yet
2 participants
@eshchenko
Copy link

commented Mar 12, 2018

Steps to reproduce the problem

The problem was investigated in configuration described in #1978

Connect external 24bit usb card to Raspberry Pi2 with fresh Raspbian installed
Compile stable DeaDBeeF 0.7.2 from source.
Use the external usb card in most direct way:
ALSA output plugin
Output device: Dr DAC Direct Hardware Device without any conversions
ALSA resampling is not enabled.

Take a 24bit file, be sure that it can be played correctly by the aplay:
pi@raspberrypi:~/development/bin $ aplay -D hw:CARD=prime,DEV=0 tmp.wav
Playing WAVE 'tmp.wav' : Signed 24 bit Little Endian in 3bytes, Rate 48000 Hz, Stereo

Start to play this 24bit pcm (*.wav) file by the deadbeef player.
Be sure the internal volume is set to the very right position +0 dB.

What's going on? Describe the problem in as much detail as possible.

Open SiperEQ window.
Enable equalizer. This will result to huge sound distortions
Disable equalizer. Distortions will disappear.

Play any 16bit file - No distortions.

Information about the software:

Deadbeef version:
0.7.2 stable
OS:
Paspberri Pi 2B
Raspbian GNU/Linux 8 (jessie)
Linux raspberrypi 4.9.35-v7+ #1014 SMP Fri Jun 30 14:47:43 BST 2017 armv7l GNU/Linux

I had also tried the last development version.
In this case the EQ does not work neither with 16bit nor with 24bit files

The signal is not changed independent on the enabling/disabling the EQ.

Additional information:

For the crosscheck I compiled the development version of the deadbeef on
Linux HP-EliteBook-8530p 4.4.0-040400-generic #201601101930 SMP Mon Jan 11 00:32:41 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
and reconnected the 24bit usb card to this Intel PC.

On Intel the SuperEQ works as expected and without distortions both with internal 32bit card and external 24bit card
(when playing 24bit file on internal card there is warning -
cannot set sample format to 24 bps (error: Invalid argument), trying all supported formats
Found compatible format 32 bps)
When playing 24bit file with 24bit card there are no warnings.

@Alexey-Yakovenko

This comment has been minimized.

Copy link
Collaborator

commented Mar 13, 2018

deadbeef 0.7 series are not going to receive updates I'm afraid. I thought that the issue was that EQ is not working at all on trunk. Is that still the case?

@Alexey-Yakovenko Alexey-Yakovenko changed the title SuperEQ problems at raspbian armv7l SuperEQ distorts 24 bit output on raspbian armv7l Mar 13, 2018

@Alexey-Yakovenko Alexey-Yakovenko changed the title SuperEQ distorts 24 bit output on raspbian armv7l SuperEQ distorts 24 bit output on raspbian armv7l in 0.7.2, and doesn't function at all in master builds Mar 13, 2018

@Alexey-Yakovenko

This comment has been minimized.

Copy link
Collaborator

commented Mar 13, 2018

So.. there was a regression that was causing this exact issue, that supereq didn't work at all. It was fixed in commit d2fc9ef. Can you please verify that your build is up to date? It sounds like you might be a few commits behind.

@eshchenko

This comment has been minimized.

Copy link
Author

commented Mar 13, 2018

@Alexey-Yakovenko Alexey-Yakovenko changed the title SuperEQ distorts 24 bit output on raspbian armv7l in 0.7.2, and doesn't function at all in master builds SuperEQ distorts 24 bit output on raspbian armv7l Mar 13, 2018

@Alexey-Yakovenko

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2018

I don't have access to ARM hardware to test this on, but I made what looks like a fix. Please let me know if the latest version works.

@eshchenko

This comment has been minimized.

Copy link
Author

commented Mar 14, 2018

@Alexey-Yakovenko

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2018

Sorry, I accidentally deleted a character from the variable name. Please try again.

@eshchenko

This comment has been minimized.

Copy link
Author

commented Mar 14, 2018

@Alexey-Yakovenko

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2018

There's no official list of supported platforms as such..
And while it's supposed to work, claiming it's "supported" would not be true, since there's no dedicated maintainer for supporting it.

Thanks for reporting and verifying the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.