New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug that causes saves to fail #19

merged 1 commit into from Aug 1, 2011


None yet
2 participants

JoshuaRogers commented Jul 31, 2011

I found a fun bug with the way that saves work. Whenever a save occurs, a lock gets set. If the save fails, the lock is never removed. Because if this, if there is ever any IO error during a save, no further saves can be performed. For me, this was a random quicksave that failed in the middle of the night last night. I only lost a day though. Glad I restarted the server now. :P

In addition to cleaning up the lock, this also makes the server attempt to save again if a save fails while shutting down.

DeathCradle added a commit that referenced this pull request Aug 1, 2011

Merge pull request #19 from JoshuaRogers/master
Bug that causes saves to fail

@DeathCradle DeathCradle merged commit efb1f73 into DeathCradle:master Aug 1, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment