-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dman support #57
Comments
|
redirectory fixed in ae44c70, thanks! |
|
i just noticed there's a debman command in the debian-goodies package. That command can show the manpage within a Sounds like another thing we could hijack. :) debman is a shellscript as well. |
|
in the meantime, could we ship the dman script in the assets and link it somewhere? maybe in the about section? i'd make a PR if that's okay with you. |
|
I’d prefer it if we could package up the dman script in a debian package (probably to experimental as we’re currently frozen). I think it’d be more confusing than useful to have different distribution channels for software, and Debian packages are definitely the best way to distribute software to Debian users :) |
|
Okay well, the problem is this will take forever to trickle down into a stable release... How about this - we figure out a debian package for our little shell script refugee and link to its source code in the FAQ? In fact, I have created a collab-maint branch for dman in debian-goodies called debiman-support which adds a Here's the source code now: https://anonscm.debian.org/git/collab-maint/debian-goodies.git/tree/dman?h=debiman-support How does that sound? |
|
The alternative to this, of course, is to package debiman directly (see #1) and make this a distinct binary package people can just install directly. Given the complexity (or I guess my unfamiliarity) with golang + debian packaging, I am tempted to just stick with this easier option, as it also doesn't involve a rewrite in go. ;) in other news, i asked to merge the branch in debian-goodies in #860920. let's see how that flies. |
|
Linking to the source of a Debian package is fine with me. |
|
debian-goodies 0.70 with dman included has just been uploaded to Debian experimental. |
|
@dustinkirkland See above and https://tracker.debian.org/news/844034 |
|
alright, I've linked to dman in the FAQ - we just need to merge the branch to complete this issue I believe - see #1 for the pipe dreams of packaging debiman and rewriting dman and so on. ;) |
|
Hey team -- first off, I'm super pleased that you find dman useful! I love it, as well. I would be very happy for Debian to ship dman in a Debian package, of course. I would just politely ask that you make it work with both Debian and Ubuntu, with a simple conditional that you can key directly off of the info you get out of the lsb-release. As such, we'll be glad to use the same dman in Ubuntu as you use in Debian. Thanks! |
|
On 2017-04-28 12:18:14, Dustin Kirkland wrote:
Hey team -- first off, I'm super pleased that you find dman useful! I love it, as well.
I would be very happy for Debian to ship dman in a Debian package, of course. I would just politely ask that you make it work with *both* Debian and Ubuntu, with a simple conditional that you can key directly off of the info you get out of the lsb-release.
As such, we'll be glad to use the same dman in Ubuntu as you use in Debian.
Hi!
I think that's a great idea. Unfortunately, I made some changes to the
script and I am not sure it still works against manpages.ubuntu.com
right now. I am certain, however, that the debian-goodies maintainer
will happily welcome patches to fix that!
The source code is here:
https://anonscm.debian.org/git/collab-maint/debian-goodies.git/tree/dman
And you can file a pull request / send a patch on the Debian-goodies
package:
https://tracker.debian.org/pkg/debian-goodies
Thanks!
|
|
@anarcat, @dustinkirkland: Yes, actually I had this issue in my mind already, too. Patches are indeed very welcome. |
|
i tried this simple patch to try and support ubuntu (based on the diff --git a/dman b/dman
index a44ecf1..fea73f7 100755
--- a/dman
+++ b/dman
@@ -61,7 +61,14 @@ if echo $LOCALE | grep -E -q "^(C|en)"; then
LOCDOT=".en"
fi
-BASE_URL="https://manpages.debian.org"
+case $(lsb_release -s -i) in
+ Ubuntu)
+ BASE_URL="https://manpages.ubuntu.com"
+ ;;
+ *)
+ BASE_URL="https://manpages.debian.org"
+ ;;
+esac
mandir=`mktemp -d dman.XXXXXX`
trap "rm -rf $mandir" EXIT HUP INT QUIT TERMunfortunately that doesn't work, because we look into debiman-specific paths and ubuntu's manpage service lacks the required redirections: even when using the the original dman had quite a bit of logic to guess the filesystem paths on the other end. we got rid of a lot of that for performance reasons: in the worst case, the original version was doing 9 requests to the server - we lowered that to 2, and jumped back to 4 to support multiple suites. so i'm not sure how to deal with this. the logic will get really hairy if we need to support site-specific patterns like this. all i can think of now is rewrite the thing in python to support parameter expansion - e.g. |
one of the great uses of manpages.d.o is for installs that do not have man installed. for this, the ubuntu people wrote this clever little script called dman which fetches the raw pages to display locally. it's pretty neat!
but out of the box, it doesn't work with the debiman layout. i had to modify the script so that it works with manpages.debian.org - here's the diff:
notice how I had to dance around the locale stuff... i posted the full script in this paste bin: http://paste.debian.net/911957/
also, the above doesn't actually work in Debian stretch because it looks for https://manpages.debian.org/stretch/manpages/intro.1.en.gz - which is a 302 into the redirector, which redirects to the HTML page:
so to fix this, we'd need to:
stretch) along with symbolic names (e.g.testing), maybe related to should use /stretch instead of /testing #54?ideally, make this part of the builtin man binary and/or package this as a separate dman binary package that can be installed for real (see also package for Debian #1 for debian packaging)was made part of the debian-goodies packagemaybe rewrite dman in go while we're at it? :p- moved to package for Debian #1The text was updated successfully, but these errors were encountered: