Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default colors for dark-themed browsers #118

Merged
merged 1 commit into from Oct 14, 2019
Merged

add default colors for dark-themed browsers #118

merged 1 commit into from Oct 14, 2019

Conversation

532910
Copy link
Contributor

@532910 532910 commented Oct 7, 2019

No description provided.

@532910 532910 mentioned this pull request Oct 7, 2019
Copy link
Contributor

@stapelberg stapelberg left a comment

Thanks for the PR!

assets/style.css Outdated
@@ -19,6 +19,8 @@
}

body {
color: #222;
Copy link
Contributor

@stapelberg stapelberg Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why #222 instead of the current #000? I thought higher contrast is better for accessibility reasons.

Copy link
Contributor Author

@532910 532910 Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I've just got it from https://www.debian.org/debian.css body's element.

Copy link
Contributor

@stapelberg stapelberg Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I think in this case high contrast is better than consistency with other debian css files. Can you change it to #000 please?

Copy link
Contributor Author

@532910 532910 Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it to '#000' and now it's Outdated here. Could you help me please?

Copy link
Contributor

@stapelberg stapelberg Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI showing outdated is okay.

assets/style.css Show resolved Hide resolved
@stapelberg stapelberg merged commit edd69f4 into Debian:master Oct 14, 2019
1 check failed
@stapelberg
Copy link
Contributor

@stapelberg stapelberg commented Oct 14, 2019

This has been deployed and should make its way onto manpages.d.o within the next few days.

@532910
Copy link
Contributor Author

@532910 532910 commented Oct 21, 2019

Still not deployed, right?

@stapelberg
Copy link
Contributor

@stapelberg stapelberg commented Oct 22, 2019

It is, but only effective for manpages that have been rendered since it was deployed. See e.g. https://manpages.debian.org/testing/freedombox/plinth.1.en.html

I’ll trigger a full re-render now, so that existing pages should be refreshed, too. It can take another few days for that change to actually make it out.

@532910
Copy link
Contributor Author

@532910 532910 commented Oct 22, 2019

plinth.1.en.html looks fine. Thank you for explanation.

0x0aba pushed a commit to 0x0aba/debian-assets that referenced this issue Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants