Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix the cmdline.txt options to boot by label, not by partition" #33

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@chschlue
Copy link
Contributor

chschlue commented Aug 22, 2018

This reverts commit 554020c.

This change wasn't functional, ${ROOT?} does not make sense in a chroot.

Also, I suggest fixing this in raspi3-firmware, cmdline.txt would get overwritten anyway on every kernel update.

@gwolf

This comment has been minimized.

Copy link
Member

gwolf commented Aug 22, 2018

You are right about this. I have locally fixed it by removing the ${ROOT?}.
I do not think this should go into raspi3-firmware, as not everybody will adhere to the partition naming scheme I chose here; I think people building their own raspberry layouts will expect things to boot from mmcblk0p1 - And will know where to look otherwise.
Am currently building an image (as you know, the process is far from quick on spinning rust), and if all's well, I will push it today.
Also, I am meaning to update the raspi3-firmware package Real Soon Now™, I just want to be sure of a couple of things before messing it up.

@gwolf gwolf closed this Aug 22, 2018

@chschlue

This comment has been minimized.

Copy link
Contributor Author

chschlue commented Aug 23, 2018

Ok, but if raspi3-firmware overwrites cmdline.txt over and over, what's the point?

@chschlue

This comment has been minimized.

Copy link
Contributor Author

chschlue commented Aug 23, 2018

This way, if you boot from USB and update your kernel some time later you're screwed and left with an unbootable system.

@gwolf

This comment has been minimized.

Copy link
Member

gwolf commented Aug 23, 2018

Ok, but if raspi3-firmware overwrites cmdline.txt over and over, what's the point?

Then that is clearly a bug! Users should be able to change their partitioning layouts without expecting the system to die. That's something that should be either configurable or detected at install time.

@gwolf

This comment has been minimized.

Copy link
Member

gwolf commented Aug 23, 2018

@chschlue, seems you are always a step ahead of me 😄

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=903543

@chschlue

This comment has been minimized.

Copy link
Contributor Author

chschlue commented Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.