Monitoring review #236
Merged
Monitoring review #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmouly
requested review from
PYLochou,
barbara-ressel,
fredmerci,
lgrateau and
siasin
siasin
reviewed
Jun 2, 2025
contrib/monitor/mpmetrics/README.md
Outdated
| > If you want to install a **specific version**, add the `--version` option: | ||
| > | ||
| > ```bash | ||
| > helm install roks-tuto ibm-helm/ibm-odm-prod --version <version> -f monitor-values.yaml |
There was a problem hiding this comment.
Should it be my-odm-release instead of roks-tuto in the helm install command?
There was a problem hiding this comment.
yes, I let it to see who will detect it ! ;-) Good catch, 1 point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.