Skip to content

global variables #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaspercooper merged 1 commit into from
Aug 22, 2018
Merged

global variables #171

jaspercooper merged 1 commit into from
Aug 22, 2018

Conversation

@acoppock
Copy link
Contributor

@acoppock acoppock commented Aug 22, 2018

different approach to gloabl variables (to be implemented for all designers!)

@coveralls
Copy link

coveralls commented Aug 22, 2018

Pull Request Test Coverage Report for Build 839

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 837: 0.0%
Covered Lines: 633
Relevant Lines: 633
💛 - Coveralls

nfultz
nfultz approved these changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@nfultz nfultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaspercooper
Copy link
Contributor

jaspercooper commented Aug 22, 2018

Byudaful, thanks

@jaspercooper jaspercooper merged commit 7f72860 into master Aug 22, 2018
@jaspercooper jaspercooper deleted the global-variables branch August 22, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nfultz nfultz nfultz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@acoppock @coveralls @jaspercooper @nfultz